Skip to content

GH-5709: added vocabularies typically used in EU projects#5739

Open
barthanssens wants to merge 1 commit intoeclipse-rdf4j:developfrom
Fedict:GH-5709-eu-vocabularies
Open

GH-5709: added vocabularies typically used in EU projects#5739
barthanssens wants to merge 1 commit intoeclipse-rdf4j:developfrom
Fedict:GH-5709-eu-vocabularies

Conversation

@barthanssens
Copy link
Copy Markdown
Contributor

@barthanssens barthanssens commented Apr 9, 2026

GitHub issue resolved: #5709

Briefly describe the changes proposed in this PR:

  • New "vocabulary.eu" package with European DCAT-AP vocabularies, ADMS (typically used in data spaces and data portals), Core Vocabularies (procedure exchange) and ELI Ontology (legislation)
  • New "vocabulary.annotation" package with OA (web annotation), DQV, DUV
  • New "vocabulary.biblio" package with BIBO, FBBR, FABIO
  • Added a copy of package-protected vocabularies helper class to "org.eclipse.rdf4j.model.base.model.base", but this time as a public class (to allow other packages to use it), albeit with InternalOnly annotation

PR Author Checklist (see the contributor guidelines for more details):

  • my pull request is self-contained
  • I've added tests for the changes I made
  • I've applied code formatting (you can use mvn process-resources to format from the command line)
  • I've squashed my commits where necessary
  • every commit message starts with the issue number (GH-xxxx) followed by a meaningful description of the change

@barthanssens barthanssens force-pushed the GH-5709-eu-vocabularies branch from 0d95797 to 8b57a97 Compare April 9, 2026 20:50
@barthanssens barthanssens self-assigned this Apr 10, 2026
@barthanssens barthanssens added the 📶 enhancement issue is a new feature or improvement label Apr 10, 2026
@hmottestad
Copy link
Copy Markdown
Contributor

@barthanssens for these new vocabularies, can you use the case from the iri name instead of all caps? It makes it a lot easier for users to find the correct vocabulary when our names are identical to the vocabulary.

@barthanssens
Copy link
Copy Markdown
Contributor Author

barthanssens commented Apr 24, 2026

@hmottestad uhm, for the java class name you mean ? e.g. GeoDCAT-AP instead of GEODCATAP ? Sure can do.

And/or for the IRIs for the RDF properties / classes as well ?

@barthanssens
Copy link
Copy Markdown
Contributor Author

So I've changed the all-uppercase IRI for classes and properties of EU vocabularies package, would you like me to do the same for the newly added (but more generic) vocabularies like BIBO in the "main" vocabularies package ?
(I think it's indeed a good idea, but it breaks the current convention used in the very old/widely used vocabularies like DCTERMS)

@hmottestad
Copy link
Copy Markdown
Contributor

So I've changed the all-uppercase IRI for classes and properties of EU vocabularies package, would you like me to do the same for the newly added (but more generic) vocabularies like BIBO in the "main" vocabularies package ?

(I think it's indeed a good idea, but it breaks the current convention used in the very old/widely used vocabularies like DCTERMS)

Thanks.

We don't need to do it for existing vocabularies or for new IRIs to existing vocabularies.

For new vocabularies it reduces confusion and improves discoverability. It's always challenging when a vocabulary uses the same term for a class and a predicate when we use uppercase for all Java constants.

@hmottestad
Copy link
Copy Markdown
Contributor

And yes, think it's a good idea to use the same case as the IRI for all new vocabulary sets we introduce.

@barthanssens
Copy link
Copy Markdown
Contributor Author

Ok, makes sense, I'll change the IRIs of the other newly added vocabularies as well

@barthanssens barthanssens force-pushed the GH-5709-eu-vocabularies branch 3 times, most recently from 36bfdb2 to 3859946 Compare April 27, 2026 09:57
@barthanssens barthanssens force-pushed the GH-5709-eu-vocabularies branch from aba486e to 4da008b Compare April 27, 2026 11:38
@barthanssens
Copy link
Copy Markdown
Contributor Author

Split / moved into newer java packages.

Also moved the Vocabularies helper class to model.base and made it public to make it reusable across packages
(actually this java class is already a copy of the package-protected one in existing ..vocabularies package, so it might be good idea to deprecated/remove that one as well, and use the now-public Vocabularies helper class to create internedIRI in the existing DCTERMS etc vocabularies. Shouldn't make a difference for the end-user)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

📶 enhancement issue is a new feature or improvement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants