GH-5735 leapfrog triejoin for LMDB Store#5736
Open
hmottestad wants to merge 32 commits intodevelopfrom
Open
Conversation
Contributor
Author
89ms down to 16.7ms, and 3814ms down to 520ms. |
Contributor
Author
|
Contributor
Author
|
hmottestad
commented
Apr 8, 2026
| public void meetOther(QueryModelNode node) throws QueryEvaluationException { | ||
| if (node instanceof TupleExpr) { | ||
| for (String bindingName : ((TupleExpr) node).getBindingNames()) { | ||
| varNames.computeIfAbsent(bindingName, k -> k); |
Contributor
Author
There was a problem hiding this comment.
Seems like we are missing some vars, because this is needed for all the tests to pass now.
Contributor
Author
Latest results: |
Contributor
Author
|
@kenwenzel When you are back from holiday you might want to take a look at this PR. I've got LFTJ working on LMDB (requires all 6 triple indexes). With some caching and codegen I've managed to get it to about 10x faster when compared to regular joins. Fairly happy with performance now. |
Member
|
@hmottestad Does this always require all 6 index combinations or could it also work in some circumstances with fewer indexes? Most stores that work with named graphs will use indexes like cspo, cosp etc. Is this also supported? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub issue resolved: #
Briefly describe the changes proposed in this PR:
PR Author Checklist (see the contributor guidelines for more details):
mvn process-resourcesto format from the command line)