Merge main into develop#5410
Merged
JervenBolleman merged 2 commits intodevelopfrom Sep 4, 2025
Merged
Conversation
The BindingSetAssingmentInlinerOptimizer attempts to inject a single value from VALUES clauses into matching variables. For SERVICE causes this is problematic (when they later get evaluated through the SparqlFederatedService): the SPARQLFederatedService computes the set of bound variables and applies logic. Here it is important, that binding set assignments are not inlined. Otherwise, a query evaluation exception is thrown due to a malformed query. The actual query at evaluation time (in case such inlining happened) would contain something like VALUES <http://www.example.com/MyResource> { <http://www.example.com/MyResource> } i.e. the variable name of the VALUES clause incorrectly replaced. This change fixes it by not applying inlining insider SERVICE nodes. Various unit tests on different levels have been added, which I used to get closer to the problem.
JervenBolleman
temporarily deployed
to
github-pages
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automatically generated PR to keep develop in sync with main.
USE MERGE COMMIT TO MERGE THIS PR.
See merge_main_to_develop.yml.