GH-5711 stabilize LMDB lifecycle integration test

Agent-Logs-Url: https://github.com/eclipse-rdf4j/rdf4j/sessions/27581789-9cfd-4609-b36b-d89427f138d0

Co-authored-by: hmottestad <797185+hmottestad@users.noreply.github.com>

Author: Copilot

core/sail/lmdb/src/test/java/org/eclipse/rdf4j/sail/lmdb/LmdbStoreModelLifecycleIT.java

@@ -15,9 +15,7 @@
 
 import java.io.File;
 import java.lang.reflect.Field;
-import java.util.concurrent.CountDownLatch;
 import java.util.concurrent.TimeUnit;
-import java.util.concurrent.atomic.AtomicReference;
 import java.util.stream.Stream;
 
 import org.eclipse.rdf4j.common.iteration.CloseableIteration;
@@ -95,67 +93,35 @@ private void preloadStatements(LmdbStore store, int round) throws Exception {
 	}
 
 	private void runLongLivedReaderRound(LmdbStore store, IsolationLevel isolationLevel, int round) throws Exception {
-		CountDownLatch readerReady = new CountDownLatch(1);
-		CountDownLatch writerFinished = new CountDownLatch(1);
-		AtomicReference<Throwable> failure = new AtomicReference<>();
-
-		Thread reader = new Thread(() -> {
-			try (SailConnection connection = store.getConnection()) {
-				connection.begin(isolationLevel);
-				try (CloseableIteration<? extends Statement> statements = connection.getStatements(null, RDFS.LABEL,
-						null,
-						false)) {
-					assertThat(statements.hasNext()).isTrue();
-					statements.next();
-					readerReady.countDown();
-					assertThat(writerFinished.await(10, TimeUnit.SECONDS)).isTrue();
-					while (statements.hasNext()) {
-						statements.next();
-						Thread.yield();
+		try (SailConnection reader = store.getConnection()) {
+			reader.begin(isolationLevel);
+			try (CloseableIteration<? extends Statement> statements = reader.getStatements(null, RDFS.LABEL, null,
+					false)) {
+				assertThat(statements.hasNext()).isTrue();
+				statements.next();
+				try (SailConnection writer = store.getConnection()) {
+					writer.begin(isolationLevel);
+					forceOverflowOnNextAdd();
+					for (int i = 0; i < REMOVED_PRELOADED_STATEMENTS; i++) {
+						writer.removeStatements(subject("preloaded", round, i), RDFS.LABEL, null);
+					}
+					for (int i = 0; i < COMMITTED_OVERFLOW_STATEMENTS; i++) {
+						writer.addStatement(subject("committed", round, i), COMMITTED_PREDICATE,
+								VF.createLiteral("committed-" + round + "-" + i));
 					}
+					writer.commit();
+				} finally {
+					clearOverflowFlag();
 				}
-				try {
-					connection.commit();
-				} catch (SailConflictException e) {
-					connection.rollback();
+				while (statements.hasNext()) {
+					statements.next();
 				}
-			} catch (Throwable t) {
-				failure.compareAndSet(null, t);
 			}
-		}, "lmdb-lifecycle-reader-" + isolationLevel + "-" + round);
-
-		Thread writer = new Thread(() -> {
-			try (SailConnection connection = store.getConnection()) {
-				assertThat(readerReady.await(10, TimeUnit.SECONDS)).isTrue();
-				connection.begin(isolationLevel);
-				forceOverflowOnNextAdd();
-				for (int i = 0; i < REMOVED_PRELOADED_STATEMENTS; i++) {
-					connection.removeStatements(subject("preloaded", round, i), RDFS.LABEL, null);
-				}
-				for (int i = 0; i < COMMITTED_OVERFLOW_STATEMENTS; i++) {
-					connection.addStatement(subject("committed", round, i), COMMITTED_PREDICATE,
-							VF.createLiteral("committed-" + round + "-" + i));
-				}
-				connection.commit();
-			} catch (Throwable t) {
-				failure.compareAndSet(null, t);
-			} finally {
-				clearOverflowFlag();
-				writerFinished.countDown();
+			try {
+				reader.commit();
+			} catch (SailConflictException e) {
+				reader.rollback();
 			}
-		}, "lmdb-lifecycle-writer-" + isolationLevel + "-" + round);
-
-		reader.start();
-		writer.start();
-
-		reader.join(TimeUnit.SECONDS.toMillis(20));
-		writer.join(TimeUnit.SECONDS.toMillis(20));
-
-		assertThat(reader.isAlive()).isFalse();
-		assertThat(writer.isAlive()).isFalse();
-		if (failure.get() != null) {
-			throw new AssertionError("Lifecycle round failed for " + isolationLevel + " round " + round,
-					failure.get());
 		}
 	}