Skip to content

Commit 8181a4a

Browse files
committed
code cleanup
1 parent 748d991 commit 8181a4a

2 files changed

Lines changed: 28 additions & 0 deletions

File tree

core/sail/api/src/main/java/org/eclipse/rdf4j/sail/helpers/AbstractSailConnection.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -723,6 +723,9 @@ public void addStatement(UpdateContext op, Resource subj, IRI pred, Value obj, R
723723
startUpdate(op);
724724
}
725725
}
726+
if (op != null) {
727+
incrementDataImportMetricsStatementsAdded(contexts);
728+
}
726729
statementsAdded = true;
727730
}
728731

core/sail/api/src/test/java/org/eclipse/rdf4j/sail/helpers/AbstractSailConnectionDataImportMetricsTest.java

Lines changed: 25 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@
3131
import org.eclipse.rdf4j.model.vocabulary.RDF;
3232
import org.eclipse.rdf4j.query.BindingSet;
3333
import org.eclipse.rdf4j.query.Dataset;
34+
import org.eclipse.rdf4j.query.algebra.InsertData;
3435
import org.eclipse.rdf4j.query.algebra.TupleExpr;
3536
import org.eclipse.rdf4j.sail.SailConnection;
3637
import org.eclipse.rdf4j.sail.SailException;
@@ -161,6 +162,30 @@ void logsDataImportMetricsWhenUpdateAddStatementIsOverridden() {
161162
assertThat(messages.get(0)).contains("statementsAdded=1");
162163
}
163164

165+
@Test
166+
void logsDataImportMetricsForBufferedUpdateStatements() {
167+
TestSail sail = new TestSail();
168+
try {
169+
sail.init();
170+
try (SailConnection connection = sail.getConnection()) {
171+
UpdateContext updateContext = new UpdateContext(new InsertData("INSERT DATA {}"), null, null, false);
172+
connection.setTransactionSettings(loadDataImportMetricsEnabled());
173+
connection.begin();
174+
connection.startUpdate(updateContext);
175+
connection.addStatement(updateContext, RDF.TYPE, RDF.TYPE, RDF.PROPERTY, VF.createIRI("urn:ctx:one"),
176+
VF.createIRI("urn:ctx:two"));
177+
connection.endUpdate(updateContext);
178+
connection.commit();
179+
}
180+
} finally {
181+
sail.shutDown();
182+
}
183+
184+
List<String> messages = appender.messages(Level.INFO);
185+
assertThat(messages).hasSize(1);
186+
assertThat(messages.get(0)).contains("statementsAdded=2");
187+
}
188+
164189
private static TransactionSetting loadDataImportMetricsEnabled() {
165190
return DataImportMetrics.ENABLED;
166191
}

0 commit comments

Comments
 (0)