Skip to content

Style ToolTip to make it dark enough in Dark mode #12420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
willibrandon wants to merge 18 commits into
base: main
Choose a base branch
from
+151 −3
Open

Style ToolTip to make it dark enough in Dark mode #12420

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
8b345fe
Disabling ToolTip visual styles to make it dark enough in Dark mode
willibrandon Nov 4, 2024
f5a017b
Feedback from code review
willibrandon Nov 6, 2024
e980d69
Fix spacing
willibrandon Nov 6, 2024
6e1fd22
More fluent assertions
willibrandon Nov 6, 2024
ae2c320
ApplicationColorModeScope feedback from code review
willibrandon Nov 7, 2024
3278d8d
Set theme to DarkMode_Explorer and round the corners with a small radius
willibrandon Nov 7, 2024
f4d6102
Assert the rounded corner preference
willibrandon Nov 7, 2024
a4ead96
Corner preference is supported starting with Windows 11 Build 22000
willibrandon Nov 7, 2024
c34aa2d
Use default corner preference for balloon windows
willibrandon Nov 8, 2024
10e0bbb
Initialize colors from dark mode explorer tooltip theme subclass
willibrandon Nov 9, 2024
d4c985b
Set colors in a similar way as ListView and TreeView
willibrandon Nov 10, 2024
674c1c7
Utilize theme for visual styles and remove the get colors test
willibrandon Nov 11, 2024
26e4f93
Remove constant
willibrandon Nov 11, 2024
05412b8
Darken the ListView ToolTip in Dark mode
willibrandon Nov 12, 2024
1e35f2b
Darken the TreeView ToolTip in Dark mode
willibrandon Nov 12, 2024
7810b62
Darken the TabControl ToolTip in Dark mode
willibrandon Nov 12, 2024
3bcc1d2
Revert unnecessary change
willibrandon Nov 12, 2024
625896f
Move to OnHandleCreated
willibrandon Nov 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 11 additions & 8 deletions src/System.Windows.Forms/src/System/Windows/Forms/ToolTip/ToolTip.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -718,6 +718,13 @@ private unsafe void CreateHandle()
{
PInvoke.SetWindowTheme(HWND, string.Empty, string.Empty);
}

#pragma warning disable WFO5001
if (Application.IsDarkModeEnabled)
Comment thread
willibrandon marked this conversation as resolved.
Outdated
{
PInvoke.SetWindowTheme(HWND, string.Empty, string.Empty);
}
#pragma warning restore WFO5001
}

// If in OwnerDraw mode, we don't want the default border.
Expand Down Expand Up @@ -770,15 +777,11 @@ private unsafe void CreateHandle()
// Set active status.
PInvokeCore.SendMessage(this, PInvoke.TTM_ACTIVATE, (WPARAM)(BOOL)_active);

if (BackColor != SystemColors.Info)
{
PInvokeCore.SendMessage(this, PInvoke.TTM_SETTIPBKCOLOR, (WPARAM)BackColor);
}
// Set background color.
PInvokeCore.SendMessage(this, PInvoke.TTM_SETTIPBKCOLOR, (WPARAM)_backColor);

if (ForeColor != SystemColors.InfoText)
{
PInvokeCore.SendMessage(this, PInvoke.TTM_SETTIPTEXTCOLOR, (WPARAM)ForeColor);
}
// Set text color.
PInvokeCore.SendMessage(this, PInvoke.TTM_SETTIPTEXTCOLOR, (WPARAM)_foreColor);

if (_toolTipIcon > 0 || !string.IsNullOrEmpty(_toolTipTitle))
{
Expand Down
30 changes: 30 additions & 0 deletions src/System.Windows.Forms/tests/UnitTests/System/Windows/Forms/ToolTipTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -782,6 +782,36 @@ public void ToolTip_ToString_Invoke_ReturnsExpected()
Assert.Equal("System.Windows.Forms.ToolTip InitialDelay: 500, ShowAlways: False", toolTip.ToString());
}

#pragma warning disable WFO5001
[WinFormsFact]
public void ToolTip_DarkMode_GetColors_ReturnsExpected()
{
if (SystemInformation.HighContrast)
{
// We don't run this test in HighContrast mode.
return;
}

SystemColorMode colorMode = Application.ColorMode;
Application.SetColorMode(SystemColorMode.Dark);

using SubToolTip toolTip = new();

Assert.NotEqual(IntPtr.Zero, toolTip.Handle); // A workaround to create the toolTip native window Handle
Comment thread
willibrandon marked this conversation as resolved.
Outdated

var backgroundColor = PInvokeCore.SendMessage(toolTip, PInvoke.TTM_GETTIPBKCOLOR);
Color backColor = ColorTranslator.FromWin32((int)backgroundColor);

var textColor = PInvokeCore.SendMessage(toolTip, PInvoke.TTM_GETTIPTEXTCOLOR);
Color foreColor = ColorTranslator.FromWin32((int)textColor);

Assert.Equal(SystemColors.Info.ToArgb(), backColor.ToArgb());
Assert.Equal(SystemColors.InfoText.ToArgb(), foreColor.ToArgb());

Application.SetColorMode(colorMode);
Comment thread
willibrandon marked this conversation as resolved.
Outdated
}
#pragma warning restore WFO5001

[WinFormsFact]
public void ToolTip_SetToolTipToControl_Invokes_SetToolTip_OfControl()
{
Expand Down