Clarify LargeChange property usage in Slider and RangeBase documentation#12597
Open
unchihugo wants to merge 3 commits intodotnet:mainfrom
Open
Clarify LargeChange property usage in Slider and RangeBase documentation#12597unchihugo wants to merge 3 commits intodotnet:mainfrom
unchihugo wants to merge 3 commits intodotnet:mainfrom
Conversation
Update property reference from SmallChange to LargeChange
dotnet-policy-service
Bot
added
the
community-contribution
Contributor
|
Tagging subscribers to this area: @dotnet/wpf-developers |
Author
|
@dotnet-policy-service agree |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the WPF API reference documentation to better describe how LargeChange is used for Slider track interactions, and fixes an incorrect reference in Slider.IsMoveToPointEnabled remarks.
Changes:
- Updates
Slider.IsMoveToPointEnabledremarks to referenceRangeBase.LargeChange(instead ofSmallChange) for track clicks when the property isfalse. - Adjusts
RangeBase.LargeChangeremarks to includeSlidertrack-click behavior alongside theDecreaseLarge/IncreaseLargecommands.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
xml/System.Windows.Controls/Slider.xml |
Fixes the IsMoveToPointEnabled remarks to describe track-click stepping in terms of LargeChange. |
xml/System.Windows.Controls.Primitives/RangeBase.xml |
Updates LargeChange remarks to describe how Slider and ScrollBar use the property. |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Slider.IsMoveToPointEnabledtrack click remark reference from SmallChange to LargeChangeRangeBase.LargeChangeproperty