Skip to content

[DCP ] Adds the indices for the schema#2012

Merged
gmechali merged 3 commits into
datacommonsorg:masterfrom
gmechali:addIndex
May 14, 2026
Merged

[DCP ] Adds the indices for the schema#2012
gmechali merged 3 commits into
datacommonsorg:masterfrom
gmechali:addIndex

Conversation

@gmechali
Copy link
Copy Markdown
Contributor

@gmechali gmechali commented May 14, 2026

And the schema now adds the two indices needed to power the SV hierarchy

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces Cloud Run deployment capabilities to the Cloud Build workflow, sets a minimum Python version of 3.12, and adds new Spanner indexes for the Edge and Observation tables. Feedback was provided regarding an invalid use of the columnar_policy option on a standard secondary index and a suggestion to make the database initialization query more robust by avoiding hardcoded table names when checking for existing indexes.

Comment thread import-automation/workflow/ingestion-helper/schema.sql
Comment thread import-automation/workflow/ingestion-helper/spanner_client.py
@gmechali gmechali changed the title [DCP ] Adds the indices for the schema + makes cloudbuild only deploy when variable is true. [DCP ] Adds the indices for the schema + small cloudbuild change May 14, 2026
@gmechali gmechali changed the title [DCP ] Adds the indices for the schema + small cloudbuild change [DCP ] Adds the indices for the schema May 14, 2026
@gmechali gmechali requested review from clincoln8 and dwnoble May 14, 2026 20:05
@gmechali gmechali merged commit 418a094 into datacommonsorg:master May 14, 2026
9 checks passed
@gmechali gmechali deleted the addIndex branch May 14, 2026 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants