This repository was archived by the owner on Feb 10, 2021. It is now read-only.
Custom script#24
Open
mrocklin wants to merge 2 commits intodask:masterfrom
Open
Conversation
set `self.script` if a custom script is specified
Member
|
Given what you have found about testing, am wondering if it would be better to just pass the script contents in as an argument. Thus it could just be written out and run. Personally have been skirting this issue by setting |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extends #22 cc @maxvitek
This adds a test and handles relative paths.
Currently the test fails. Oddly having a
remoteCommandthat is an absolute path seems to fail while having aremoteCommandthat is of the form./foo.shworks fine. cc @davidr in case he has thoughts on why this might be.