Skip to content

Fixed #14735 (dumpfile: Value::intvalue with negative value for unsigned expression) #8540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danmar merged 2 commits into from
May 7, 2026
+15 −1
Merged

Fixed #14735 (dumpfile: Value::intvalue with negative value for unsigned expression) #8540

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f495809
Fixed #14735 (dumpfile: Value::intvalue with negative value for unsig…
danmar May 7, 2026
3297e7a
comment
danmar May 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/token.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1816,7 +1816,7 @@ void Token::printValueFlow(const std::vector<std::string>& files, bool xml, std:
outs += " <value ";
switch (value.valueType) {
case ValueFlow::Value::ValueType::INT:
if (tok->valueType() && tok->valueType()->sign == ValueType::UNSIGNED) {
if (tok->valueType() && tok->valueType()->sign == ValueType::UNSIGNED && value.toString() != "!<=-1") {
outs += "intvalue=\"";
outs += MathLib::toString(static_cast<MathLib::biguint>(value.intvalue));
outs += '\"';
Expand Down
14 changes: 14 additions & 0 deletions test/testsymboldatabase.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -632,6 +632,8 @@ class TestSymbolDatabase : public TestFixture {
TEST_CASE(stdintFunction);

TEST_CASE(userDefinedLiteral);

TEST_CASE(dumpValueNegative); // #14735 - dumping negative impossible value for unsigned expression
}

void array() {
Expand Down Expand Up @@ -11444,6 +11446,18 @@ class TestSymbolDatabase : public TestFixture {
ASSERT(!x->varId());
ASSERT(!x->variable());
}

void dumpValueNegative() { // #14735
GET_SYMBOL_DB("void f(unsigned int x) { a = x; }");
const Token* x = Token::findsimplematch(tokenizer.tokens(), "x ;");
ASSERT(x != nullptr);
std::ostringstream out;
x->printValueFlow({"test.cpp"}, true, out);
const std::string dump = out.str();
const std::string expected = "<value intvalue=\"-1\" bound=\"Upper\" impossible=\"true\" path=\"0\"/>";
// dump should contain expected string, otherwise print the dump string
ASSERT_EQUALS(expected, dump.find(expected) == std::string::npos ? dump : expected);
}
};

REGISTER_TEST(TestSymbolDatabase)
Loading