Open
Conversation
This implementation is copied nearly verbatim from the prototype colcon_python_project package.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #732 +/- ##
==========================================
+ Coverage 87.21% 87.52% +0.31%
==========================================
Files 69 73 +4
Lines 4106 4241 +135
Branches 709 720 +11
==========================================
+ Hits 3581 3712 +131
- Misses 414 420 +6
+ Partials 111 109 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cottsay
commented
Apr 1, 2026
Comment on lines
+28
to
+30
| extend_ignore=[ | ||
| 'D100', 'D101', 'D102', 'D103', 'D104', 'D105', 'D106', 'D107', | ||
| ], |
Member
Author
There was a problem hiding this comment.
I added D106 to this list. Evidently we've never had a nested class definition in the test sources, but it makes sense to suppress the documentation requirement there as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implementation is copied nearly verbatim from the prototype
colcon_python_projectpackage.Here's the spec for PEP 517: https://peps.python.org/pep-0517/
This is the central component for enabling colcon to act as a "build frontend" and the Python package build process will be built around this infrastructure. Additionally, non-PEP 518 packages will extract package metadata during the identification and augmentation phases of the colcon workflow.
To help visualize where this fits in the overall standards-based Python build picture, this hook caller interface will invoke the appropriate backend hook (e.x.
build_wheel) for a package to build a wheel file, and then colcon will install that wheel (after uninstalling any previous wheels for that package) into the install space.The decoration infrastructure allows us to add backend-specific augmentations to hook invocations. Though this interface should allow colcon to support arbitrary backends, we'll implement decorators for "helping" the backends to support broader scenarios (like symlink installs) and optimize the overall process. For example, we'll need to augment
setuptoolsbuilds in order to maintain feature parity with colcon's existing setuptools integration. We'll also use that decorator to move temporary artifacts out of the package source directory.