-
Notifications
You must be signed in to change notification settings - Fork 87
fix(tokenizers): raise ValueError instead of TypeError when Content-Length is absent #764
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
xodn348
wants to merge
1
commit into
cohere-ai:main
Choose a base branch
from
xodn348:fix/tokenizer-config-size-none-type
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,47 @@ | ||
| import sys | ||
| import types | ||
| import unittest | ||
| from unittest.mock import MagicMock, patch | ||
|
|
||
| # Stub out the `tokenizers` C-extension so the module can be imported in CI | ||
| # without the native library present. | ||
| if "tokenizers" not in sys.modules: | ||
| tokenizers_stub = types.ModuleType("tokenizers") | ||
| tokenizers_stub.Tokenizer = object # type: ignore[attr-defined] | ||
| sys.modules["tokenizers"] = tokenizers_stub | ||
|
|
||
| from cohere.manually_maintained.tokenizers import _get_tokenizer_config_size | ||
|
|
||
|
|
||
| class TestGetTokenizerConfigSize(unittest.TestCase): | ||
| def _make_head_response(self, headers: dict) -> MagicMock: | ||
| resp = MagicMock() | ||
| resp.headers = headers | ||
| return resp | ||
|
|
||
| def test_content_length_header(self) -> None: | ||
| with patch("requests.head", return_value=self._make_head_response({"Content-Length": "2097152"})): | ||
| size = _get_tokenizer_config_size("https://example.com/tokenizer.json") | ||
| self.assertAlmostEqual(size, 2.0) | ||
|
|
||
| def test_goog_stored_content_length_header(self) -> None: | ||
| with patch("requests.head", return_value=self._make_head_response({"x-goog-stored-content-length": "1048576"})): | ||
| size = _get_tokenizer_config_size("https://example.com/tokenizer.json") | ||
| self.assertAlmostEqual(size, 1.0) | ||
|
|
||
| def test_goog_header_takes_priority_over_content_length(self) -> None: | ||
| with patch( | ||
| "requests.head", | ||
| return_value=self._make_head_response( | ||
| {"x-goog-stored-content-length": "1048576", "Content-Length": "2097152"} | ||
| ), | ||
| ): | ||
| size = _get_tokenizer_config_size("https://example.com/tokenizer.json") | ||
| self.assertAlmostEqual(size, 1.0) | ||
|
|
||
| def test_raises_value_error_when_no_size_header(self) -> None: | ||
| """Chunked-transfer responses omit Content-Length; must raise ValueError, not TypeError.""" | ||
| with patch("requests.head", return_value=self._make_head_response({})): | ||
| with self.assertRaises(ValueError) as ctx: | ||
| _get_tokenizer_config_size("https://example.com/tokenizer.json") | ||
| self.assertIn("Content-Length unavailable", str(ctx.exception)) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
keep the typing cast here unless you had a specific reason to remove it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.