fix: resolve java method calls to long signature definitions correctly#183
Open
li-jin-gou wants to merge 3 commits intomainfrom
Open
fix: resolve java method calls to long signature definitions correctly#183li-jin-gou wants to merge 3 commits intomainfrom
li-jin-gou wants to merge 3 commits intomainfrom
Conversation
f95f66a to
80d7d2e
Compare
80d7d2e to
08a223f
Compare
When a method calls another method that is defined later in the same class, the current single-pass logic fails to find the callee method symbol and creates a stub. This commit introduces a two-pass approach within `processClass`: 1. Iterate over methods and create definitions/symbols. 2. Iterate over methods again to process method calls and resolve them against the symbols created in the first pass.
08a223f to
a6d57bb
Compare
wzekin
approved these changes
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Check the PR title.
(Optional) Translate the PR title into Chinese.
(Optional) More detailed description for this PR(en: English/zh: Chinese).
en:
zh(optional):
(Optional) Which issue(s) this PR fixes:
(optional) The PR that updates user documentation: