chore(clerk-js): manifest for cross-bundle internal ABI#8567
Draft
jacekradko wants to merge 1 commit into
Draft
Conversation
🦋 Changeset detectedLatest commit: 41f4961 The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
jacekradko
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a manifest of the
__internal_*members on the liveClerkinstance that are reached at runtime from outside@clerk/clerk-js(34 entries acrossreact,shared,expo,ui,astro,vue,chrome-extension). A contract test verifies each manifest entry is declared inclerk.ts; a usage scanner walks every otherpackages/*/src/**and asserts the reach sites match. Both trip if they drift apart.Motivation is #8559 and #8562: PR #8434 removed
clerk.__internal_queryClientbecause nothing in this monorepo called it, but@clerk/shared@4.6.0(shipped inside@clerk/nextjs@7.0.12) was reading it on the CDN-loadedclerk-js. With this manifest, that removal would have failed the scanner at PR time.