fix: allow release creation to trigger workflows#534
Open
hspitzley-czi wants to merge 2 commits intomainfrom
Open
fix: allow release creation to trigger workflows#534hspitzley-czi wants to merge 2 commits intomainfrom
hspitzley-czi wants to merge 2 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split release-please into two steps
Previously a single
googleapis/release-please-action@v4call handled both PR creation and release creation. Whenpreserve_filesis set, the action usesGITHUB_TOKENto silence the branch push — but this also silenced release creation, breakingon: releasedownstream workflows.The fix splits the action into two calls:
release_pr(skip-github-release: true) — handles PR branch creation/update only, uses the silent token strategy when neededrelease(skip-github-pull-request: true) — handles GitHub release creation only, always usesapp_tokenso release events trigger downstream workflowsPR-related output references (
prs_created,prs) now come fromsteps.release_pr.outputs; release-related references (release_created,major,minor) remain onsteps.release.outputs.