When automatically disables task, remeber to set no_changes = False#887
Open
tdybda17 wants to merge 1 commit intocelery:mainfrom
Open
When automatically disables task, remeber to set no_changes = False#887tdybda17 wants to merge 1 commit intocelery:mainfrom
tdybda17 wants to merge 1 commit intocelery:mainfrom
Conversation
auvipy
requested changes
May 12, 2025
Member
auvipy
left a comment
There was a problem hiding this comment.
the change will also need some unit tests to verify it and to avoid any regression
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #887 +/- ##
==========================================
+ Coverage 87.62% 87.94% +0.32%
==========================================
Files 32 32
Lines 1010 1012 +2
Branches 81 104 +23
==========================================
+ Hits 885 890 +5
+ Misses 107 104 -3
Partials 18 18 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
pre-commit failures: |
Contributor
|
Please rebase to fix the linter failure. |
Member
|
@alirafiei75 can you check this locally? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.