fix: add LibreOffice fallback for reliable .doc file conversion#2065
Open
octo-patch wants to merge 1 commit intobytedance:mainfrom
Open
fix: add LibreOffice fallback for reliable .doc file conversion#2065octo-patch wants to merge 1 commit intobytedance:mainfrom
octo-patch wants to merge 1 commit intobytedance:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2002
Problem
Legacy
.docfiles are listed inCONVERTIBLE_EXTENSIONSbut conversion is unreliable. MarkItDown does not have a dependable path for legacy Word.docfiles (only.docxworks well). When conversion fails silently, the upload appears to succeed but no usable markdown is produced — the agent cannot read the file content.Solution
Add an explicit
.dochandling path in_do_convert():.doc→.docxin a temp directory, then run MarkItDown on the resulting.docx. This is the reliable path when LibreOffice is installed.RuntimeErrorexplicitly if the MarkItDown fallback also produces empty output, soconvert_file_to_markdown()returnsNoneinstead of writing an empty.mdfile. The file upload itself still succeeds; only the markdown conversion is skipped..docxand all other formats are unchanged.Testing
TestTryConvertDocToDocxwith 4 unit tests covering: soffice not found, soffice success, soffice non-zero exit, soffice timeout.TestDoConvertcovering.docrouting: soffice available, soffice unavailable with content, soffice unavailable with empty output (raises).test_file_conversion.py).