Fixes simple form with validation groups and buttons inside#40
Open
ikselll wants to merge 1 commit intoboekkooi:masterfrom
Open
Fixes simple form with validation groups and buttons inside#40ikselll wants to merge 1 commit intoboekkooi:masterfrom
ikselll wants to merge 1 commit intoboekkooi:masterfrom
Conversation
Owner
|
Hi @ikselll, Thanks you for the PR but it seems that no test was provided/changed. Would it be possible to for you to add a test or to? I can update the tests but I would like to have a case provided that shows me why this is needed. Thank you in advance! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because of this line simple form with button and model with asserts with validation groups will not work.
$enabled_validation_groups will be empty array because form has button.
I fixed it but maybe it breaks BC with other bundles. Please check it