ci: bump the github-actions group with 6 updates#453
Conversation
Bumps the github-actions group with 6 updates: | Package | From | To | | --- | --- | --- | | [github/codeql-action](https://github.com/github/codeql-action) | `4.35.1` | `4.35.2` | | [actions/cache](https://github.com/actions/cache) | `5.0.4` | `5.0.5` | | [actions/create-github-app-token](https://github.com/actions/create-github-app-token) | `3.0.0` | `3.1.1` | | [cachix/install-nix-action](https://github.com/cachix/install-nix-action) | `31.10.4` | `31.10.5` | | [zizmorcore/zizmor-action](https://github.com/zizmorcore/zizmor-action) | `0.5.2` | `0.5.3` | | [ruby/setup-ruby](https://github.com/ruby/setup-ruby) | `1.300.0` | `1.302.0` | Updates `github/codeql-action` from 4.35.1 to 4.35.2 - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@c10b806...95e58e9) Updates `actions/cache` from 5.0.4 to 5.0.5 - [Release notes](https://github.com/actions/cache/releases) - [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md) - [Commits](actions/cache@6682284...27d5ce7) Updates `actions/create-github-app-token` from 3.0.0 to 3.1.1 - [Release notes](https://github.com/actions/create-github-app-token/releases) - [Commits](actions/create-github-app-token@f8d387b...1b10c78) Updates `cachix/install-nix-action` from 31.10.4 to 31.10.5 - [Release notes](https://github.com/cachix/install-nix-action/releases) - [Changelog](https://github.com/cachix/install-nix-action/blob/master/RELEASE.md) - [Commits](cachix/install-nix-action@6165592...ab73962) Updates `zizmorcore/zizmor-action` from 0.5.2 to 0.5.3 - [Release notes](https://github.com/zizmorcore/zizmor-action/releases) - [Commits](zizmorcore/zizmor-action@71321a2...b1d7e1f) Updates `ruby/setup-ruby` from 1.300.0 to 1.302.0 - [Release notes](https://github.com/ruby/setup-ruby/releases) - [Changelog](https://github.com/ruby/setup-ruby/blob/master/release.rb) - [Commits](ruby/setup-ruby@e65c17d...7372622) --- updated-dependencies: - dependency-name: github/codeql-action dependency-version: 4.35.2 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: github-actions - dependency-name: actions/cache dependency-version: 5.0.5 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: github-actions - dependency-name: actions/create-github-app-token dependency-version: 3.1.1 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: github-actions - dependency-name: cachix/install-nix-action dependency-version: 31.10.5 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: github-actions - dependency-name: zizmorcore/zizmor-action dependency-version: 0.5.3 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: github-actions - dependency-name: ruby/setup-ruby dependency-version: 1.302.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: github-actions ... Signed-off-by: dependabot[bot] <support@github.com>
Sensitive Change Detection (shadow mode)This PR modifies control-plane files:
|
There was a problem hiding this comment.
Pull request overview
Tip
If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or run gh pr ready --undo.
Click "Ready for review" or run gh pr ready to reengage.
This PR updates pinned GitHub Actions across the CI/security/release workflows to keep the pipeline current and incorporate upstream fixes.
Changes:
- Bump
github/codeql-actionpins tov4.35.2in CodeQL/SARIF upload workflows. - Bump
actions/cachepins tov5.0.5andruby/setup-rubytov1.302.0in test workflows. - Bump
actions/create-github-app-tokentov3.1.1, andcachix/install-nix-actiontov31.10.5in release workflow.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/test.yml | Update pins for zizmor, cache, setup-ruby, and cache restore/save steps. |
| .github/workflows/security.yml | Update codeql-action/upload-sarif pin to v4.35.2. |
| .github/workflows/scorecard.yml | Update codeql-action/upload-sarif pin to v4.35.2. |
| .github/workflows/release.yml | Update cache + nix pins; bump create-github-app-token and switch to client-id input. |
| .github/workflows/codeql.yml | Update CodeQL init/analyze/upload-sarif pins to v4.35.2. |
Comments suppressed due to low confidence (2)
.github/workflows/release.yml:127
actions/create-github-app-tokenv3.1.x addsclient-id, but this workflow is currently passingvars.RELEASE_CLIENT_IDwhich (per RELEASING.md) is a GitHub App ID. GitHub App ID and client ID are different identifiers; passing an App ID toclient-idis likely to fail token generation. Consider keepingapp-id: ${{ vars.RELEASE_CLIENT_ID }}(still supported, though deprecated) or rename/swap the repo variable to store the actual GitHub App client ID and update documentation accordingly.
- name: Generate token for Homebrew tap
id: sdk-token
uses: actions/create-github-app-token@1b10c78c7865c340bc4f6099eb2f838309f1e8c3 # v3.1.1
with:
client-id: ${{ vars.RELEASE_CLIENT_ID }}
private-key: ${{ secrets.RELEASE_APP_PRIVATE_KEY }}
owner: basecamp
repositories: homebrew-tap
permission-contents: write
.github/workflows/release.yml:402
- Same issue as earlier token step:
client-id: ${{ vars.RELEASE_CLIENT_ID }}appears to be an App ID variable (per RELEASING.md). This should likely remainapp-iduntil the variable value is switched to a real GitHub App client ID.
- name: Generate token for skills repo
id: skills-token
uses: actions/create-github-app-token@1b10c78c7865c340bc4f6099eb2f838309f1e8c3 # v3.1.1
with:
client-id: ${{ vars.RELEASE_CLIENT_ID }}
private-key: ${{ secrets.RELEASE_APP_PRIVATE_KEY }}
owner: basecamp
repositories: skills
permission-contents: write
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
… client ID (per RELEASING.md)
|
Fixed — reverted |
There was a problem hiding this comment.
1 issue found across 1 file (changes from recent commits).
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name=".github/workflows/release.yml">
<violation number="1" location=".github/workflows/release.yml:123">
P2: Use `client-id` instead of deprecated `app-id` for create-github-app-token v3.1.1.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
Bumps the github-actions group with 6 updates:
4.35.14.35.25.0.45.0.53.0.03.1.131.10.431.10.50.5.20.5.31.300.01.302.0Updates
github/codeql-actionfrom 4.35.1 to 4.35.2Release notes
Sourced from github/codeql-action's releases.
Changelog
Sourced from github/codeql-action's changelog.
... (truncated)
Commits
95e58e9Merge pull request #3824 from github/update-v4.35.2-d2e135a736f31bfeUpdate changelog for v4.35.2d2e135aMerge pull request #3823 from github/update-bundle/codeql-bundle-v2.25.260abb65Add changelog note5a0a562Update default bundle to codeql-bundle-v2.25.26521697Merge pull request #3820 from github/dependabot/github_actions/dot-github/wor...3c45af2Merge pull request #3821 from github/dependabot/npm_and_yarn/npm-minor-345b93...f1c3393Rebuild1024fc4Rebuild9dd4cfeBump the npm-minor group across 1 directory with 6 updatesUpdates
actions/cachefrom 5.0.4 to 5.0.5Release notes
Sourced from actions/cache's releases.
Changelog
Sourced from actions/cache's changelog.
... (truncated)
Commits
27d5ce7Merge pull request #1747 from actions/yacaovsnc/update-dependencyf280785licensed changes619aeb1npm run build generated dist filesbcf16c2Update ts-http-runtime to 0.3.5Updates
actions/create-github-app-tokenfrom 3.0.0 to 3.1.1Release notes
Sourced from actions/create-github-app-token's releases.
Commits
1b10c78build(release): 3.1.1 [skip ci]07e2b76fix: improve error message when app identifier is empty (#362)ea01216ci: remove publish-immutable-action workflow (#361)7bd0371build(release): 3.1.0 [skip ci]e6bd4e6feat: addclient-idinput and deprecateapp-id(#353)076e948feat: update permission inputs (#358)3bbe07dfix(deps): bump p-retry from 7.1.1 to 8.0.0 (#357)28a99e3build(deps-dev): bump c8 from 10.1.3 to 11.0.04df5060build(deps-dev): bump open-cli from 8.0.0 to 9.0.04843c53build(deps-dev): bump the development-dependencies group with 3 updatesUpdates
cachix/install-nix-actionfrom 31.10.4 to 31.10.5Release notes
Sourced from cachix/install-nix-action's releases.
Commits
ab73962Merge pull request #274 from cachix/create-pull-request/patch41e4d4anix: 2.34.5 -> 2.34.6Updates
zizmorcore/zizmor-actionfrom 0.5.2 to 0.5.3Release notes
Sourced from zizmorcore/zizmor-action's releases.
Commits
b1d7e1fSync zizmor versions (#102)a195b57Sync zizmor versions (#100)629d5d0chore(deps): bump github/codeql-action in the github-actions group (#99)453d591chore(deps): bump the github-actions group with 2 updates (#98)ea2c18bBump pins (#97)Updates
ruby/setup-rubyfrom 1.300.0 to 1.302.0Release notes
Sourced from ruby/setup-ruby's releases.
Commits
7372622Give a better error for TruffleRuby 34+ on macOS Intel4c56a21Darwin-x86_64 is no longer supported on TruffleRuby 34+5d9c71dAdd truffleruby-34.0.0,truffleruby+graalvm-34.0.0Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore <dependency name> major versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)@dependabot ignore <dependency name> minor versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)@dependabot ignore <dependency name>will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)@dependabot unignore <dependency name>will remove all of the ignore conditions of the specified dependency@dependabot unignore <dependency name> <ignore condition>will remove the ignore condition of the specified dependency and ignore conditionsSummary by cubic
Update CI workflows to newer pinned versions of key GitHub Actions to keep security scans, builds, and releases current. Upgraded
actions/create-github-app-tokento 3.1.1 but kept theapp-idinput sinceRELEASE_CLIENT_IDstores an App ID.github/codeql-action4.35.2,actions/cache5.0.5,actions/create-github-app-token3.1.1,cachix/install-nix-action31.10.5,zizmorcore/zizmor-action0.5.3,ruby/setup-ruby1.302.0.Written for commit 11cbf0a. Summary will update on new commits. Review in cubic