Refactor shuttle into shuttle-core, shuttle-schedulers, shuttle-sync sub-crates#286
Open
jorajeev wants to merge 1 commit into
Open
Refactor shuttle into shuttle-core, shuttle-schedulers, shuttle-sync sub-crates#286jorajeev wants to merge 1 commit into
jorajeev wants to merge 1 commit into
Conversation
Extract the monolithic shuttle crate into a workspace of focused sub-crates: - shuttle-core: runtime, scheduler traits, execution engine, annotations, config, thread-local key, batch semaphore, and curated internal API surface - shuttle-schedulers: all scheduler implementations (random, PCT, DFS, round-robin, replay, annotation, URW, uncontrolled nondeterminism) - shuttle-sync: sync primitives (mutex, rwlock, condvar, barrier, once, atomics, mpsc), thread, rand, lazy_static, and future spawn/JoinHandle Also adds shuttle-tests skeleton crate for future test migration and renames the wrappers/shuttle_sync package to shuttle-sync-wrapper to avoid name collision with the new shuttle-sync crate. This PR only adds (well copies) code from existing crates, but doesn't wire in anything yet, so there should be no upstream impact. A follow-up PR will remove the code from the shuttle/ crate and switch over to using the new crates.
jorajeev
changed the title
sarsko
reviewed
May 14, 2026
| @@ -1,5 +1,5 @@ | |||
| [package] | |||
| name = "shuttle-sync" | |||
| name = "shuttle-sync-wrapper" | |||
Contributor
|
I am fine with this way of doing it, we should make it not fail checks |
Contributor
|
Actually strike that, this way of doing it sounds like a great way to not keep stuff up to date and to make a headache, why are we not moving stuff out and reexporting? We don't have to move everything all at once |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extract the monolithic shuttle crate into a workspace of focused sub-crates:
shuttle-core: runtime, scheduler traits, execution engine, annotations, config, thread-local key, batch semaphore, and curated internal API surfaceshuttle-schedulers: all scheduler implementations (random, PCT, DFS, round-robin, replay, annotation, URW, uncontrolled nondeterminism)shuttle-sync: sync primitives (mutex, rwlock, condvar, barrier, once, atomics, mpsc), thread, rand, lazy_static, and future spawn/JoinHandleAlso adds
shuttle-testsskeleton crate for future test migration and renames thewrappers/shuttle_syncpackage toshuttle-sync-wrapperto avoid name collision with the newshuttle-synccrate.This PR only adds (well copies) code from existing crates, but doesn't wire in anything yet, so there should be no upstream impact. A follow-up PR will remove the code from the
shuttlecrate and switch over to using the new crates.First step towards addressing #249
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.