Skip to content

fix(lambda-nodejs): if entry path is not under project root, bundling in Docker fails in an unclear way#37572

Merged
mergify[bot] merged 4 commits intomainfrom
huijbers/lambda-nodejs-tests
Apr 13, 2026
Merged

fix(lambda-nodejs): if entry path is not under project root, bundling in Docker fails in an unclear way#37572
mergify[bot] merged 4 commits intomainfrom
huijbers/lambda-nodejs-tests

Conversation

@rix0rrr
Copy link
Copy Markdown
Contributor

@rix0rrr rix0rrr commented Apr 10, 2026

Since I'm going to be making changes here in the near future and the code of this library has accreted a lot over time and probably has many subtle edge cases, I'm starting by establishing an exhaustive testing suite.

One additional validation added in the course of this work: if the handler entry point is not under the project root, bundling inside a Docker container fails (because the entry point will not be under a mounted path), with an inscrutable error message.

Catch that case early on as a misconfiguration, and report on it.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Since I'm going to be making changes here in the near future and the
code of this library has accreted a lot over time and probably has
many subtle edge cases, I'm starting by establishing an exhaustive
testing suite.
@rix0rrr rix0rrr requested a review from a team April 10, 2026 14:27
@github-actions github-actions Bot added the p2 label Apr 10, 2026
@aws-cdk-automation aws-cdk-automation requested a review from a team April 10, 2026 14:27
@mergify mergify Bot added the contribution/core This is a PR that came from AWS. label Apr 10, 2026
@mrgrain mrgrain added the pr/do-not-merge This PR should not be merged at this time. label Apr 13, 2026
@mrgrain
Copy link
Copy Markdown
Contributor

mrgrain commented Apr 13, 2026

Approved but you are changing library code in this PR, so should be labeled as a fix and describe the changes. Please fix before merging.

@rix0rrr rix0rrr changed the title chore: a solid suite of end-to-end tests for lambda-nodejs fix(lambda-nodejs): if entry path is not under project root, bundling in Docker fails in an unclear way Apr 13, 2026
@rix0rrr rix0rrr removed the pr/do-not-merge This PR should not be merged at this time. label Apr 13, 2026
Copy link
Copy Markdown
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@rix0rrr rix0rrr added the pr-linter/exempt-integ-test The PR linter will not require integ test changes label Apr 13, 2026
@aws-cdk-automation aws-cdk-automation dismissed their stale review April 13, 2026 09:22

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Apr 13, 2026

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Apr 13, 2026

Merge Queue Status

  • Entered queue2026-04-13 10:13 UTC · Rule: default-squash
  • Checks passed · in-place
  • Merged2026-04-13 10:43 UTC · at 323267e956e77d20ec39fc646845f484dc9a8755

This pull request spent 30 minutes in the queue, including 29 minutes 46 seconds running CI.

Required conditions to merge

@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Apr 13, 2026

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify Bot merged commit 73662df into main Apr 13, 2026
19 of 20 checks passed
@mergify mergify Bot deleted the huijbers/lambda-nodejs-tests branch April 13, 2026 10:43
@github-actions
Copy link
Copy Markdown
Contributor

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Apr 13, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

contribution/core This is a PR that came from AWS. p2 pr-linter/exempt-integ-test The PR linter will not require integ test changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants