fix(lambda-nodejs): if entry path is not under project root, bundling in Docker fails in an unclear way#37572
Conversation
Since I'm going to be making changes here in the near future and the code of this library has accreted a lot over time and probably has many subtle edge cases, I'm starting by establishing an exhaustive testing suite.
|
Approved but you are changing library code in this PR, so should be labeled as a fix and describe the changes. Please fix before merging. |
lambda-nodejs✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Merge Queue Status
This pull request spent 30 minutes in the queue, including 29 minutes 46 seconds running CI. Required conditions to merge
|
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
Since I'm going to be making changes here in the near future and the code of this library has accreted a lot over time and probably has many subtle edge cases, I'm starting by establishing an exhaustive testing suite.
One additional validation added in the course of this work: if the handler entry point is not under the project root, bundling inside a Docker container fails (because the entry point will not be under a mounted path), with an inscrutable error message.
Catch that case early on as a misconfiguration, and report on it.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license