Update FSharp.Control.TaskSeq to 1.1.1#1
Closed
auduchinok wants to merge 1 commit intomasterfrom
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates FSharp.Control.TaskSeq dependency to a version that supports dynamic invocation without inlining.
The context is I'm working on dotnet/fsharp#19548 which improves debugging experience by preventing inlining where possible and allowing stepping into
inlinefunctions and setting breakpoints there. The problem the compiler CI found is the older FSharp.Control.TaskSeq version does not allow dynamic execution, so preventing inlining there would lead to exceptions in IcedTask tests. It was implemented in fsprojects/FSharp.Control.TaskSeq#380, and updating the version fixes the tests when no inlining is happening.