ESA-HST: Improve get_datalabs_path for eHST#3578
Open
jespinosaar wants to merge 4 commits intoastropy:mainfrom
Open
ESA-HST: Improve get_datalabs_path for eHST#3578jespinosaar wants to merge 4 commits intoastropy:mainfrom
jespinosaar wants to merge 4 commits intoastropy:mainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3578 +/- ##
==========================================
+ Coverage 73.22% 73.24% +0.01%
==========================================
Files 226 226
Lines 21000 21011 +11
==========================================
+ Hits 15378 15389 +11
Misses 5622 5622 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
Checks completed successfully, please review them at your earliest convenience. Many thanks in advance for your feedback! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dear Astroquery team,
As the number of collections available in ESA HST Module has grown, we had to extend the get_datalabs_path method to consider different paths depending on the type of the product we want to retrieve.
As always, we are open to your feedback.
Many thanks!
@jespinosaar
cc @esdc-esac-esa-int