Conversation
…w, may never come back. wayback machine URL added to config
|
This needs a changelog. And maybe separating out into two PRs, one for the backup url (I expect that to get merged quickly); and the other for the new kwarg (if it needs more work)? |
|
The backup doesn't do anything without the new kwarg, so these should go together. I will fix the failures tonight - this was an emergency patch with my student, since she needs access now. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3547 +/- ##
==========================================
+ Coverage 72.66% 73.24% +0.57%
==========================================
Files 219 226 +7
Lines 20478 20968 +490
==========================================
+ Hits 14880 15357 +477
- Misses 5598 5611 +13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bsipocz
left a comment
There was a problem hiding this comment.
jplspec seems to be back right now, do you still want to go ahead with the wayback machine addition?
| by the query service. This workaround is needed while JPLSpec's query | ||
| tool is broken. | ||
|
|
||
| use_getmolecule is an option to force the query to use get_molecule. |
There was a problem hiding this comment.
outside of scope here, but these methods should have proper docstrings
|
are you sure it's back? If you run a query, you probably get |
All tests pass locally on |
|
Huh, you're right. I'll dig a little more, maybe I can default the fallback to 'off'. |
This is a harder workaround for jplspec being down: it switches to using the wayback machine instead of jpl's server, which has gone totally unresponsive.
This raises bigger questions about data preservation/curation. Can't answer those here, but here's a 🩹 .