Skip to content

JPLSpec is even more down#3547

Open
keflavich wants to merge 6 commits intoastropy:mainfrom
keflavich:jplspec_2026
Open

JPLSpec is even more down#3547
keflavich wants to merge 6 commits intoastropy:mainfrom
keflavich:jplspec_2026

Conversation

@keflavich
Copy link
Copy Markdown
Contributor

This is a harder workaround for jplspec being down: it switches to using the wayback machine instead of jpl's server, which has gone totally unresponsive.

This raises bigger questions about data preservation/curation. Can't answer those here, but here's a 🩹 .

…w, may never come back. wayback machine URL added to config
@bsipocz bsipocz added this to the 0.4.12 milestone Mar 4, 2026
@bsipocz
Copy link
Copy Markdown
Member

bsipocz commented Mar 4, 2026

This needs a changelog. And maybe separating out into two PRs, one for the backup url (I expect that to get merged quickly); and the other for the new kwarg (if it needs more work)?

@keflavich
Copy link
Copy Markdown
Contributor Author

The backup doesn't do anything without the new kwarg, so these should go together. I will fix the failures tonight - this was an emergency patch with my student, since she needs access now.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 10, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.24%. Comparing base (e49f51a) to head (a94b6ec).
⚠️ Report is 137 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3547      +/-   ##
==========================================
+ Coverage   72.66%   73.24%   +0.57%     
==========================================
  Files         219      226       +7     
  Lines       20478    20968     +490     
==========================================
+ Hits        14880    15357     +477     
- Misses       5598     5611      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Member

@bsipocz bsipocz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jplspec seems to be back right now, do you still want to go ahead with the wayback machine addition?

by the query service. This workaround is needed while JPLSpec's query
tool is broken.

use_getmolecule is an option to force the query to use get_molecule.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

outside of scope here, but these methods should have proper docstrings

@keflavich
Copy link
Copy Markdown
Contributor Author

are you sure it's back? If you run a query, you probably get Zero lines were found for your search criteria. for all inputs

@bsipocz
Copy link
Copy Markdown
Member

bsipocz commented Apr 13, 2026

are you sure it's back? If you run a query, you probably get Zero lines were found for your search criteria. for all inputs

All tests pass locally on main, and https://spec.jpl.nasa.gov/ftp/pub/catalog also works? (Testing from home network and not from within caltech)

@keflavich
Copy link
Copy Markdown
Contributor Author

Huh, you're right. I'll dig a little more, maybe I can default the fallback to 'off'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants