fix(spark): mod/pmod returns NULL instead of NaN for float division by zero#21557
Merged
andygrove merged 2 commits intoapache:mainfrom Apr 13, 2026
Merged
fix(spark): mod/pmod returns NULL instead of NaN for float division by zero#21557andygrove merged 2 commits intoapache:mainfrom
andygrove merged 2 commits intoapache:mainfrom
Conversation
nuno-faria
approved these changes
Apr 12, 2026
Contributor
nuno-faria
left a comment
nuno-faria
left a comment
There was a problem hiding this comment.
Thanks @buraksenn, I leave just a small suggestion below.
coderfender
pushed a commit
to coderfender/datafusion
that referenced
this pull request
Apr 14, 2026
…y zero (apache#21557) ## Which issue does this PR close? - Closes apache#21514. ## Rationale for this change please see issue ## What changes are included in this PR? adjust pmod and mod to return NULL as expected ## Are these changes tested? added and adjusted tests ## Are there any user-facing changes? This methods will return NULL instead of Nan on this specific case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
please see issue
What changes are included in this PR?
adjust pmod and mod to return NULL as expected
Are these changes tested?
added and adjusted tests
Are there any user-facing changes?
This methods will return NULL instead of Nan on this specific case.