Skip to content

Add DiskProvisionedIops/ThroughputMibps pipeline options for the Java and GO SDKs and update Go client libraries#38349

Merged
damccorm merged 7 commits intoapache:masterfrom
bambadiouf1:restore-disk-opts-java-go
May 1, 2026
Merged

Add DiskProvisionedIops/ThroughputMibps pipeline options for the Java and GO SDKs and update Go client libraries#38349
damccorm merged 7 commits intoapache:masterfrom
bambadiouf1:restore-disk-opts-java-go

Conversation

@bambadiouf1
Copy link
Copy Markdown
Contributor

This pull request introduces two new pipeline options for the Google Cloud Dataflow runner for the Java and Go SDKs. These options allow users to specify provisioned performance for worker VM disks:

disk_provisioned_iops: Sets the provisioned IOPS for the disk. If unspecified, the service chooses a default
disk_provisioned_throughput_mibps: Sets the provisioned throughput in MiB/s for the disk.

Tests have been added/updated to verify that these options are correctly parsed and translated.

More context:
we need to add these pipeline options before submitting this cl: https://critique.corp.google.com/cl/858930428
Issue: #37374

Additionally, the Go Google API client dependencies were updated to their latest versions to allow the Go SDK to recognize the newly introduced DiskProvisionedIops and DiskProvisionedThroughputMibps fields in the Dataflow API. Several other Go client libraries and dependencies in sdks/go.mod have also been indirectly updated to their latest versions as well.

Note: The pipeline options for the python SDK will be introduced in a separate pull request


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enables users to configure provisioned IOPS and throughput for worker VM disks in Google Cloud Dataflow pipelines. By introducing these pipeline options, users can now explicitly control disk performance, which is essential for workloads with specific I/O requirements. The changes include updates to the Java and Go SDKs, along with necessary dependency upgrades to ensure compatibility with the updated Dataflow API.

Highlights

  • New Pipeline Options: Added disk_provisioned_iops and disk_provisioned_throughput_mibps options to the Google Cloud Dataflow runner for both Java and Go SDKs.
  • Dependency Updates: Updated Go Google API client libraries and other dependencies in sdks/go.mod to support the new Dataflow API fields.
  • Testing: Added unit tests for both Java and Go implementations to verify correct parsing and translation of the new disk performance options.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces support for configuring disk provisioned IOPS and throughput for Dataflow workers in both the Java and Go SDKs. Key changes include the addition of new pipeline options, updates to the Dataflow API client version, and modifications to the job translation logic to propagate these settings to worker pools. Corresponding unit tests were added to ensure the options are correctly handled. Feedback was provided regarding an incorrect issue reference in the changelog documentation.

Comment thread CHANGES.md Outdated
@codecov
Copy link
Copy Markdown

codecov Bot commented May 1, 2026

Codecov Report

❌ Patch coverage is 88.88889% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 48.73%. Comparing base (b05fbf4) to head (363840e).
⚠️ Report is 26 commits behind head on master.

Files with missing lines Patch % Lines
...m/runners/dataflow/DataflowPipelineTranslator.java 0.00% 3 Missing and 2 partials ⚠️
sdks/go/pkg/beam/io/fhirio/common.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #38349      +/-   ##
============================================
- Coverage     57.34%   48.73%   -8.61%     
- Complexity     5120    13021    +7901     
============================================
  Files          1393     2032     +639     
  Lines        197972   183250   -14722     
  Branches       4826    10614    +5788     
============================================
- Hits         113522    89306   -24216     
- Misses        80614    88257    +7643     
- Partials       3836     5687    +1851     
Flag Coverage Δ
go 28.67% <96.55%> (+0.14%) ⬆️
java 64.28% <0.00%> (-6.60%) ⬇️
python ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 1, 2026

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 1, 2026

Assigning reviewers:

R: @jrmccluskey for label go.
R: @damccorm for label build.

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@bambadiouf1
Copy link
Copy Markdown
Contributor Author

assign set of reviewers

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 1, 2026

Reviewers are already assigned to this PR: @jrmccluskey @damccorm

Copy link
Copy Markdown
Contributor

@damccorm damccorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@damccorm damccorm merged commit ca70eaa into apache:master May 1, 2026
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants