Skip to content

Clean up remaining references to Samza runner#38326

Merged
Abacn merged 3 commits intoapache:masterfrom
Abacn:cleanup-samza
Apr 30, 2026
Merged

Clean up remaining references to Samza runner#38326
Abacn merged 3 commits intoapache:masterfrom
Abacn:cleanup-samza

Conversation

@Abacn
Copy link
Copy Markdown
Contributor

@Abacn Abacn commented Apr 29, 2026

Fix #35448

Kept Samza runner website page and roadmap page noting the support is discontinued as of Beam 2.74.0

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request systematically removes outdated references to the Apache Samza runner across various parts of the project. This effort aligns with the decision to discontinue support for the Samza runner as of Beam 2.74.0, ensuring that the codebase, CI/CD pipelines, and user-facing documentation accurately reflect the current state of supported runners. The changes aim to reduce maintenance overhead and prevent confusion, while preserving a note about its discontinuation on relevant website pages.

Highlights

  • CI Configuration Updates: Removed Samza-specific test jobs and configurations from GitHub Actions prefetcher and Jenkins-related scripts and files, streamlining the continuous integration process.
  • Documentation Cleanup: Eliminated detailed descriptions and examples of the Samza runner from the 'Tour of Beam' learning content and updated the runners skill documentation to reflect its discontinuation.
  • Website Data Refinement: Removed Samza runner entries from the capability matrix and its link from the website's roadmap menu, ensuring current information is presented to users.
  • Script and Tooling Removal: Deleted several internal scripts and configuration files related to Jenkins job management that contained Samza runner references, reducing maintenance overhead.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes references to the Samza runner across the repository, including documentation, the capability matrix, and various configuration files. While most changes correctly target Samza-specific lines, a review comment points out that several CI scripts and job definition files (such as jenkins_jobs.txt and mass_comment.py) were deleted entirely. These files appear to contain critical infrastructure for other runners like Dataflow, Flink, and Spark, suggesting that they should be edited to remove Samza references rather than being removed completely.

I am having trouble creating individual review comments. Click here to see my feedback.

release/src/main/scripts/jenkins_jobs.txt (1-115)

high

The removal of this file and several other scripts (mass_comment.py, comment_pr_trigger_phrases.sh, and their resources) appears to be an overreach for a PR focused on cleaning up Samza runner references. These files contain trigger phrases and logic for many other runners (Dataflow, Flink, Spark, etc.) and general CI tasks that are unrelated to Samza. If the intention is only to remove Samza-related references, please edit these files to remove the specific Samza lines instead of deleting the files entirely. If these files are truly obsolete for all runners (e.g., due to a full migration to GitHub Actions), please clarify this in the PR description as it is a significant change to the repository's CI infrastructure.

@github-actions
Copy link
Copy Markdown
Contributor

Assigning reviewers:

R: @damccorm for label build.
R: @kennknowles for label website.

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

Copy link
Copy Markdown
Contributor

@damccorm damccorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Abacn Abacn merged commit 73985e5 into apache:master Apr 30, 2026
94 of 98 checks passed
@Abacn Abacn deleted the cleanup-samza branch April 30, 2026 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Task]: Remove support of Samza runner in new Beam versions

2 participants