Clean up remaining references to Samza runner#38326
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request systematically removes outdated references to the Apache Samza runner across various parts of the project. This effort aligns with the decision to discontinue support for the Samza runner as of Beam 2.74.0, ensuring that the codebase, CI/CD pipelines, and user-facing documentation accurately reflect the current state of supported runners. The changes aim to reduce maintenance overhead and prevent confusion, while preserving a note about its discontinuation on relevant website pages. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request removes references to the Samza runner across the repository, including documentation, the capability matrix, and various configuration files. While most changes correctly target Samza-specific lines, a review comment points out that several CI scripts and job definition files (such as jenkins_jobs.txt and mass_comment.py) were deleted entirely. These files appear to contain critical infrastructure for other runners like Dataflow, Flink, and Spark, suggesting that they should be edited to remove Samza references rather than being removed completely.
I am having trouble creating individual review comments. Click here to see my feedback.
release/src/main/scripts/jenkins_jobs.txt (1-115)
The removal of this file and several other scripts (mass_comment.py, comment_pr_trigger_phrases.sh, and their resources) appears to be an overreach for a PR focused on cleaning up Samza runner references. These files contain trigger phrases and logic for many other runners (Dataflow, Flink, Spark, etc.) and general CI tasks that are unrelated to Samza. If the intention is only to remove Samza-related references, please edit these files to remove the specific Samza lines instead of deleting the files entirely. If these files are truly obsolete for all runners (e.g., due to a full migration to GitHub Actions), please clarify this in the PR description as it is a significant change to the repository's CI infrastructure.
|
Assigning reviewers: R: @damccorm for label build. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
Fix #35448
Kept Samza runner website page and roadmap page noting the support is discontinued as of Beam 2.74.0
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.