Improve bq cdc scalability#38015
Conversation
|
R: @ahmedabu98 |
|
R: @damccorm |
|
/gemini review |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
1 similar comment
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces significant scalability improvements to the BigQuery Change Data Capture (CDC) reader. By enabling recursive stream splitting and offloading the CPU-intensive task of decompressing and converting Arrow batches to a distributed fan-out step, the reader can now handle much larger workloads more efficiently. Additionally, the switch to ZSTD compression provides better performance for data transfer. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request enhances the BigQuery change history reader by introducing recursive stream splitting for better parallelism and a fan-out mechanism to distribute Arrow decompression across workers. Key changes include the addition of _split_all_streams to subdivide read streams during initial restriction and the _DecompressArrowBatchesFn to handle deferred row decoding. The default compression codec has also been updated to ZSTD. Review feedback highlights potential performance issues regarding synchronous RPC calls during splitting, high gRPC connection churn from frequent client resets, and redundant schema parsing during batch decompression.
|
Lint workflow is failing on master too |
ahmedabu98
left a comment
There was a problem hiding this comment.
Overall looks good, just left a few comments.
Can we add a test for the max_split_rounds case too?
P.S. let's update this documentation to say to_pylist: https://github.com/claudevdm/beam/blob/e08e9d56e5ee8ece43cc15967d0edff107651554/sdks/python/apache_beam/io/gcp/bigquery_change_history.py#L882
|
I'll defer to Ahmed's review here since he has started it and he knows more than me here :) |
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.