Skip to content

Improve bq cdc scalability#38015

Merged
claudevdm merged 3 commits intoapache:masterfrom
claudevdm:bq-cdc-split-read-streams
Apr 1, 2026
Merged

Improve bq cdc scalability#38015
claudevdm merged 3 commits intoapache:masterfrom
claudevdm:bq-cdc-split-read-streams

Conversation

@claudevdm
Copy link
Copy Markdown
Collaborator

  • Further split initial read streams
  • Fan out decompression of arrow batches (by far the most expensive step and limited by parallization of number of read streams otherwise)
  • Use more efficient compression

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@claudevdm
Copy link
Copy Markdown
Collaborator Author

R: @ahmedabu98

@claudevdm
Copy link
Copy Markdown
Collaborator Author

R: @damccorm

@claudevdm
Copy link
Copy Markdown
Collaborator Author

/gemini review

@github-actions
Copy link
Copy Markdown
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

1 similar comment
@github-actions
Copy link
Copy Markdown
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces significant scalability improvements to the BigQuery Change Data Capture (CDC) reader. By enabling recursive stream splitting and offloading the CPU-intensive task of decompressing and converting Arrow batches to a distributed fan-out step, the reader can now handle much larger workloads more efficiently. Additionally, the switch to ZSTD compression provides better performance for data transfer.

Highlights

  • Enhanced Parallelism: Implemented recursive stream splitting in the BigQuery Read SDF to increase parallelism for large tables.
  • Distributed Decompression: Added an option to emit raw Arrow batches, allowing decompression and conversion to be distributed across multiple workers via a fan-out pattern.
  • Performance Optimization: Switched to ZSTD compression for Arrow serialization to improve efficiency.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request enhances the BigQuery change history reader by introducing recursive stream splitting for better parallelism and a fan-out mechanism to distribute Arrow decompression across workers. Key changes include the addition of _split_all_streams to subdivide read streams during initial restriction and the _DecompressArrowBatchesFn to handle deferred row decoding. The default compression codec has also been updated to ZSTD. Review feedback highlights potential performance issues regarding synchronous RPC calls during splitting, high gRPC connection churn from frequent client resets, and redundant schema parsing during batch decompression.

Comment thread sdks/python/apache_beam/io/gcp/bigquery_change_history.py
Comment thread sdks/python/apache_beam/io/gcp/bigquery_change_history.py
Comment thread sdks/python/apache_beam/io/gcp/bigquery_change_history.py Outdated
@claudevdm
Copy link
Copy Markdown
Collaborator Author

Lint workflow is failing on master too

Copy link
Copy Markdown
Contributor

@ahmedabu98 ahmedabu98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, just left a few comments.

Can we add a test for the max_split_rounds case too?

P.S. let's update this documentation to say to_pylist: https://github.com/claudevdm/beam/blob/e08e9d56e5ee8ece43cc15967d0edff107651554/sdks/python/apache_beam/io/gcp/bigquery_change_history.py#L882

Comment thread sdks/python/apache_beam/io/gcp/bigquery_change_history.py
Comment thread sdks/python/apache_beam/io/gcp/bigquery_change_history.py Outdated
Comment thread sdks/python/apache_beam/io/gcp/bigquery_change_history.py
Comment thread sdks/python/apache_beam/io/gcp/bigquery_change_history_it_test.py Outdated
@damccorm
Copy link
Copy Markdown
Contributor

I'll defer to Ahmed's review here since he has started it and he knows more than me here :)

Copy link
Copy Markdown
Contributor

@ahmedabu98 ahmedabu98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@claudevdm claudevdm merged commit b39a95f into apache:master Apr 1, 2026
96 of 112 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants