Sleeps after eventual scan RPC failures#6315
Open
keith-turner wants to merge 1 commit intoapache:2.1from
Open
Conversation
Fixes two problems. First the scan server client side plugins were not computing a sleep time based on observed errors. This could cause aggressive retries with scans. Modified the provided plugins to compute this. Second the batch scanner code was not properly collecting the information needed by scan server client side plugin to know if errors happened. The batch scanner code was not collecting information for all tablets, just a somewhat random subset of them. Corrected it to collect for all tablets. Also made the batch scanner code properly report failed tablets to the client side scan server plugin. Both changes together fix apache#6313. Manually tested the batch scanner code changes by adding logs and running test to ensure the correct sleeps were happening. Also manually tested the scanner to ensure it was working correctly and sleeping as expected after errors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes two problems. First the scan server client side plugins were not computing a sleep time based on observed errors. This could cause aggressive retries with scans. Modified the provided plugins to compute this.
Second the batch scanner code was not properly collecting the information needed by scan server client side plugin to know if errors happened. The batch scanner code was not collecting information for all tablets, just a somewhat random subset of them. Corrected it to collect for all tablets. Also made the batch scanner code properly report failed tablets to the client side scan server plugin.
Both changes together fix #6313. Manually tested the batch scanner code changes by adding logs and running test to ensure the correct sleeps were happening. Also manually tested the scanner to ensure it was working correctly and sleeping as expected after errors.