fix: use navigate for Electron session links#22024
Closed
ahmedfe wants to merge 1 commit intoanomalyco:devfrom
Closed
fix: use navigate for Electron session links#22024ahmedfe wants to merge 1 commit intoanomalyco:devfrom
ahmedfe wants to merge 1 commit intoanomalyco:devfrom
Conversation
github-actions
bot
added
the
needs:compliance
Contributor
|
This PR doesn't fully meet our contributing guidelines and PR template. What needs to be fixed:
Please edit this PR description to address the above within 2 hours, or it will be automatically closed. If you believe this was flagged incorrectly, please let a maintainer know. |
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
Author
|
this is the pr number 22024 |
Contributor
|
This pull request has been automatically closed because it was not updated to meet our contributing guidelines within the 2-hour window. Feel free to open a new pull request that follows our guidelines. |
github-actions
bot
removed
the
needs:compliance
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR 22024
Closes #22024
Type of change
What does this PR do?
Fixes an Electron issue where clicking a session from the sidebar could leave the session view empty, even though selecting the workspace loaded the last session correctly.
The change updates session sidebar navigation to call the router's
navigate()API explicitly instead of relying only on link navigation. This matches the working workspace navigation path and fixes the empty session view when switching sessions in Electron.How did you verify your code works?
Tested locally in the Electron app by switching between sessions from the sidebar and confirming the selected session now loads correctly.
I also ran
bun typecheckinpackages/app, but it is currently blocked by a pre-existing unrelated error inpackages/app/src/custom-elements.d.ts.Screenshots / recordings
Not included.
Checklist