Skip to content

nav with updated class name#49

Open
vcfvct wants to merge 1 commit intoalphapapa:masterfrom
vcfvct:fix-nav-border-bottom-color
Open

nav with updated class name#49
vcfvct wants to merge 1 commit intoalphapapa:masterfrom
vcfvct:fix-nav-border-bottom-color

Conversation

@vcfvct
Copy link
Copy Markdown

@vcfvct vcfvct commented Nov 13, 2018

Github updated the nav class name form .underline-nav-item to UnderlineNav-item, also need to remove the overall nav border color to make it consistent.
dom

before

border-before

after

border-after

@jgkamat
Copy link
Copy Markdown
Collaborator

jgkamat commented Nov 14, 2018 via email

@alphapapa
Copy link
Copy Markdown
Owner

Thanks. Should we remove the border color altogether as you have here, or should we add it to the missing spots?

@vcfvct vcfvct closed this Nov 11, 2020
@alphapapa alphapapa reopened this Nov 12, 2020
@alphapapa
Copy link
Copy Markdown
Owner

@vcfvct Why did you close this PR? Is it still applicable?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants