Open
Conversation
brentru
previously requested changes
Apr 17, 2026
tyeth
dismissed
brentru’s stale review
github doesn't mark requested changes as done despite resolved comments
lorennorman
approved these changes
Apr 20, 2026
Contributor
lorennorman
left a comment
lorennorman
left a comment
There was a problem hiding this comment.
This makes sense to me. Loving the overall concept of extracting transport from component type.
My note as usual is about reducing visual noise. I also noticed we prefix a lot of stuff in i2c with Device... that I may apply tidiness pressure to. General rule would be "as simple as possible but no simpler", so I'm happy to be swayed by any reason to keep the verbosity.
To me, ws.spi.Config... reads just beautifully, while Device is redundant and adds noise.
| package ws.spi; | ||
|
|
||
| /** SPI device configuration — bus selection and pin assignments. */ | ||
| message DeviceConfig { |
Contributor
There was a problem hiding this comment.
How about just Config?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #172