forked from DataDog/datadog-agent
-
Notifications
You must be signed in to change notification settings - Fork 3
Stac 0 produce images #405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
zandrewitte
wants to merge
85
commits into
master
Choose a base branch
from
stac-0-produce-images
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 34 commits
Commits
Show all changes
85 commits
Select commit
Hold shift + click to select a range
687d9cf
WIP publish images
zandrewitte 1f962b3
push deb base and main runner
zandrewitte 82cd662
gitlab ci runners wip
zandrewitte 6bc0ba6
gitlab ci runners wip
zandrewitte f41ffee
build runners using docker
zandrewitte 7aa81c3
build runners using docker
zandrewitte 493c2a4
cleanup / fixes
zandrewitte d6be4cc
use shell for date
zandrewitte 798c37f
Fix version discovery
zandrewitte 2a9e14c
add docker service
zandrewitte 7a8d39e
update base deb image building
zandrewitte 1b808e5
login to docker registry
zandrewitte 5c04d96
push to docker and quay
zandrewitte a234f23
disable quay for now
zandrewitte 2842636
lint fixes
zandrewitte 1b26965
fix cd in runner main
zandrewitte 248e95e
gitlab ci cleanup / refactor, try publishing deb-rpm publisher
zandrewitte fb0726a
produce centos7 container
zandrewitte 343294b
fix yaml inherit
zandrewitte b71019b
produce centos6 runner base
zandrewitte 8465a99
make docker variables global
zandrewitte 2a08018
fix runner image version variables
zandrewitte 689f365
skip centos6, generalize main runner base
zandrewitte 06cf523
produce centos7 image
zandrewitte b5a5168
point to newly release images, make the publish image manual trigger …
zandrewitte 54aa7c6
Merge branch 'master' into stac-0-produce-images
julianosk 7ac47d5
Use sts version of rpm-s3
julianosk fa627f0
Add manual job to publish image
julianosk bab0336
Use docker image
julianosk 02d61b5
Install make before build and push
julianosk b19ae8b
Allow to publish runner
julianosk b09080b
Enable [build_runners]
julianosk c02acc1
Update rpmpublisher image
julianosk 601d490
Update to rpm image to deb-rpmpublisher_20211216
julianosk ae02aae
Set sts-rpm-s3 to 0.3.3 [build_runners]
julianosk 8564d72
Fix molecule kubernetes test
julianosk 38e3706
Merge branch 'master' into stac-0-produce-images
julianosk a4f1642
test commit
zandrewitte 038e793
remove test commit
zandrewitte 4bbb6e4
build runner for deb_rpm publisher using Py2 instead of Py3 [build_ru…
zandrewitte fe01a56
switch runner
zandrewitte d01b2d0
build publisher base, use publisher base when building deb-rpm publisher
zandrewitte 8bf537d
Merge branch 'master' into stac-0-produce-images
zandrewitte b6f5a96
[build_runners] documentation
zandrewitte 6521ee5
get rid of entrypoint in deb-rpm publisher image
zandrewitte 8b6492a
fix runner publisher base dir [build_runners]
zandrewitte 55e97ed
try using deb7_latest for deb-rpm publisher
zandrewitte 38b25b8
test new commit
zandrewitte 6beb78d
revert test commit and [build_runners]
zandrewitte 46f1dac
add entrypoint to deactivate conda [build_runners]
zandrewitte c12d573
copy entrypoint script [build_runners]
zandrewitte 03118a0
Merge branch 'master' into stac-0-produce-images
julianosk 00fb4cc
STAC-15134 trigger agent runners build [build_runners]
julianosk 0e691f8
STAC-15134 trigger build_agent_runners
julianosk 0664eab
STAC-15134 Attempt to fix build_agent_runners
julianosk 88162c9
STAC-15134 Add stage to build-deb-base
julianosk ea818c6
STAC-15134 Run build_runner_base
julianosk db926d2
STAC-15134 Add rules to docker_build_base
julianosk dbb43d9
STAC-15134 Fix builders folder path
julianosk cadc690
STAC-15134 Fix builders folder path [2]
julianosk 3252b92
STAC-15134 Fix rvm gpg keys
julianosk f479c33
STAC-15134 Fix rvm gpg keys [2]
julianosk 58a487f
STAC-15134 Change rpmpublisher base image to python
julianosk 69287ff
STAC-15134 Refactor everything
julianosk d247daa
STAC-15134 Fix base runner script
julianosk aedfb6b
STAC-15134 Fix BASE_RUNNER_TAG [build_runners]
julianosk 77fa654
STAC-15134 Fix build_runner [build_runners]
julianosk 9389351
STAC-15134 Debug error
julianosk 322fd0c
STAC-15134 Debug BASE_RUNNER_TAG
julianosk 82c0469
STAC-15134 Debug BASE_RUNNER_TAG [2]
julianosk b8c81dc
STAC-15134 Debug BASE_RUNNER_TAG [3]
julianosk 4262836
STAC-15134 Full build
julianosk e92d72d
STAC-15134 Fix debian-rpmpublisher-runner
julianosk 019acf5
STAC-15134 Update images
julianosk 09c6be0
STAC-15134 Add lexicon to debian and gpg to rpmpublisher
julianosk 1e727ea
STAC-15134 Update rpmpublisher and debian images [build_runners]
julianosk 1d11bcf
STAC-15134 Add lexicon to centos7 [build_runners]
julianosk 16e8fce
STAC-15134 Fix sign_rpm_package.sh [build_runners]
julianosk 87cca7f
STAC-15134 Use constant for rpmpublisher
julianosk 30394f0
STAC-15134 update centos7 image and push to quay.io
julianosk 73c8cec
STAC-15134 Add lexicon to centos7 [build_runners]
julianosk 020010d
STAC-15134 Attempt to use centos7 image to release_rpm [build_runners]
julianosk 6f817c2
STAC-15134 Fix quay.io push and use previous release_rpm image [build…
julianosk 74b8d37
STAC-15134 Version pin pip deps
julianosk 01ae655
STAC-16520 Downgrade boto3 to be compatible with awscli 1.16
julianosk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| FROM docker.io/stackstate/stackstate-agent-runner-circle:latest | ||
|
|
||
| RUN pip install awscli boto3 sa-rpm-s3 | ||
| RUN pip install awscli boto3 sts-rpm-s3 | ||
| #RUN apt-get install -y libkrb5-dev unixodbc-dev rpm python-deltarpm createrepo yum-utils | ||
|
|
||
| ADD rpmmacros /root/.rpmmacros |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,15 +1,23 @@ | ||
| RUNTIMETAG := $(shell date +%Y%m%d) | ||
| DOCKER_REPOSITORY ?= docker.io | ||
|
|
||
| version: | ||
| echo $(RUNTIMETAG) | tail -1 > version.txt | ||
|
|
||
| build: | ||
| docker build -t docker.io/stackstate/stackstate-agent-runner-circle:deb7_$(RUNTIMETAG) . | ||
| docker build -t $(DOCKER_REPOSITORY)/stackstate/stackstate-agent-runner-circle:deb7_$(RUNTIMETAG) . | ||
|
|
||
| tag: | ||
| docker tag $(DOCKER_REPOSITORY)/stackstate/stackstate-agent-runner-circle:deb7_$(RUNTIMETAG) $(DOCKER_REPOSITORY)/stackstate/stackstate-agent-runner-circle:deb7_$(RUNTIMETAG) | ||
|
|
||
| push: | ||
| docker push docker.io/stackstate/stackstate-agent-runner-circle:deb7_$(RUNTIMETAG) | ||
| docker push $(DOCKER_REPOSITORY)/stackstate/stackstate-agent-runner-circle:deb7_$(RUNTIMETAG) | ||
|
|
||
| try: | ||
| docker run -it docker.io/stackstate/stackstate-agent-runner-circle:deb7_$(RUNTIMETAG) sh | ||
| docker run -it $(DOCKER_REPOSITORY)/stackstate/stackstate-agent-runner-circle:deb7_$(RUNTIMETAG) sh | ||
|
|
||
| tag_latest: | ||
| docker tag docker.io/stackstate/stackstate-agent-runner-circle:deb7_$(RUNTIMETAG) docker.io/stackstate/stackstate-agent-runner-circle:deb7_latest | ||
| docker tag $(DOCKER_REPOSITORY)/stackstate/stackstate-agent-runner-circle:deb7_$(RUNTIMETAG) $(DOCKER_REPOSITORY)/stackstate/stackstate-agent-runner-circle:deb7_latest | ||
|
|
||
| push_latest: | ||
| docker push docker.io/stackstate/stackstate-agent-runner-circle:deb7_latest | ||
| docker push $(DOCKER_REPOSITORY)/stackstate/stackstate-agent-runner-circle:deb7_latest |
580 changes: 0 additions & 580 deletions
580
.cd-builders/runner7-circle-deb/rvm/gpg-keys/mpapis.asc
This file was deleted.
Oops, something went wrong.
51 changes: 0 additions & 51 deletions
51
.cd-builders/runner7-circle-deb/rvm/gpg-keys/pkuczynski.asc
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,13 +1,18 @@ | ||
| RUNTIMETAG := $(shell date +%Y%m%d) | ||
| DOCKER_REPOSITORY ?= docker.io | ||
|
|
||
| version: | ||
| echo $(RUNTIMETAG) | tail -1 > version.txt | ||
|
|
||
|
|
||
| build: | ||
| docker build -t docker.io/stackstate/stackstate-agent-runner-circle:centos6_$(RUNTIMETAG)_v7 . | ||
| docker build -t $(DOCKER_REPOSITORY)/stackstate/stackstate-agent-runner-circle:centos6_$(RUNTIMETAG) . | ||
| push: | ||
| docker push docker.io/stackstate/stackstate-agent-runner-circle:centos6_$(RUNTIMETAG)_v7 | ||
| docker push $(DOCKER_REPOSITORY)/stackstate/stackstate-agent-runner-circle:centos6_$(RUNTIMETAG) | ||
|
|
||
| tag_latest: | ||
| docker tag docker.io/stackstate/stackstate-agent-runner-circle:centos6_$(RUNTIMETAG)_v7 docker.io/stackstate/stackstate-agent-runner-circle:centos6_latest_v7 | ||
| docker tag $(DOCKER_REPOSITORY)/stackstate/stackstate-agent-runner-circle:centos6_$(RUNTIMETAG) $(DOCKER_REPOSITORY)/stackstate/stackstate-agent-runner-circle:centos6_latest | ||
|
|
||
| push_latest: | ||
| docker push docker.io/stackstate/stackstate-agent-runner-circle:centos6_latest_v7 | ||
| docker push $(DOCKER_REPOSITORY)/stackstate/stackstate-agent-runner-circle:centos6_latest | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,8 +5,7 @@ ARG GIMME_GO_VERSION=1.13.11 | |
| ARG DD_CONDA_VERSION=4.7.10 | ||
| ARG DD_PIP_VERSION=19.1 | ||
| ARG DD_SETUPTOOLS_VERSION=41.0.1 | ||
| # 9.1.0.9 | ||
| ARG IBM_MQ_VERSION=9.2.0.0 | ||
| ARG IBM_MQ_VERSION=9.2.4.0 | ||
| ARG CMAKE_VERSION=3.14.4 | ||
| ARG CLANG_VERSION=8.0.0 | ||
|
Comment on lines
7
to
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same comment as the other Dockerfiles |
||
|
|
||
|
|
@@ -158,7 +157,7 @@ RUN mkdir -p /go/src/github.com/DataDog/datadog-agent | |
| # Force umask to 0022 | ||
| RUN echo "umask 0022" >> /root/.bashrc | ||
|
|
||
| RUN pip install awscli boto3 sa-rpm-s3 | ||
| RUN pip install awscli boto3 sts-rpm-s3 | ||
|
|
||
| RUN yum -y install net-snmp-devel python-deltarpm yum-utils libtool rpm-sign createrepo | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,13 +1,18 @@ | ||
| RUNTIMETAG := $(shell date +%Y%m%d) | ||
| DOCKER_REPOSITORY ?= docker.io | ||
|
|
||
| version: | ||
| echo $(RUNTIMETAG) | tail -1 > version.txt | ||
|
|
||
| build: | ||
| docker build -t docker.io/stackstate/stackstate-agent-runner-circle:centos7_$(RUNTIMETAG)_v7 . | ||
| docker build -t $(DOCKER_REPOSITORY)/stackstate/stackstate-agent-runner-circle:centos7_$(RUNTIMETAG) . | ||
|
|
||
| push: | ||
| docker push docker.io/stackstate/stackstate-agent-runner-circle:centos7_$(RUNTIMETAG)_v7 | ||
| docker push $(DOCKER_REPOSITORY)/stackstate/stackstate-agent-runner-circle:centos7_$(RUNTIMETAG) | ||
|
|
||
| tag_latest: | ||
| docker tag docker.io/stackstate/stackstate-agent-runner-circle:centos7_$(RUNTIMETAG)_v7 docker.io/stackstate/stackstate-agent-runner-circle:centos7_latest_v7 | ||
| docker tag $(DOCKER_REPOSITORY)/stackstate/stackstate-agent-runner-circle:centos7_$(RUNTIMETAG) $(DOCKER_REPOSITORY)/stackstate/stackstate-agent-runner-circle:centos7_latest | ||
|
|
||
| push_latest: | ||
| docker push docker.io/stackstate/stackstate-agent-runner-circle:centos7_latest_v7 | ||
| docker push $(DOCKER_REPOSITORY)/stackstate/stackstate-agent-runner-circle:centos7_latest | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,7 @@ | ||
| FROM docker.io/stackstate/stackstate-agent-runner-circle:latest | ||
| ARG BASE_RUNNER_IMAGE_VERSION=deb7_latest | ||
| FROM docker.io/stackstate/stackstate-agent-runner-circle:${BASE_RUNNER_IMAGE_VERSION} | ||
|
|
||
| RUN pip install boto3 sa-rpm-s3 invoke distro==1.4.0 awscli==1.16 | ||
| RUN pip install boto3 sts-rpm-s3 invoke distro==1.4.0 awscli==1.16 | ||
| RUN apt update && apt-get install -y libkrb5-dev unixodbc-dev rpm python-deltarpm createrepo yum-utils | ||
|
|
||
| ADD rpmmacros /root/.rpmmacros |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,8 @@ | ||
| RUNTIMETAG := $(shell date +%Y%m%d) | ||
| DOCKER_REPOSITORY ?= docker.io | ||
| BASE_RUNNER_IMAGE_VERSION ?= deb7_latest | ||
|
|
||
| build: | ||
| docker build -t docker.io/stackstate/stackstate-agent-runner-gitlab:deb-rpmpublisher . | ||
| docker build --build-arg BASE_RUNNER_IMAGE_VERSION=$(BASE_RUNNER_IMAGE_VERSION) -t $(DOCKER_REPOSITORY)/stackstate/stackstate-agent-runner-gitlab:deb-rpmpublisher_$(RUNTIMETAG) . | ||
| push: | ||
| docker push docker.io/stackstate/stackstate-agent-runner-gitlab:deb-rpmpublisher | ||
| docker push $(DOCKER_REPOSITORY)/stackstate/stackstate-agent-runner-gitlab:deb-rpmpublisher_$(RUNTIMETAG) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,13 @@ | ||
| RUNTIMETAG := $(shell date +%Y%m%d) | ||
| DOCKER_REPOSITORY ?= docker.io | ||
| BASE_RUNNER_IMAGE_VERSION ?= deb7_latest | ||
|
|
||
| version: | ||
| echo $(RUNTIMETAG) | tail -1 > version.txt | ||
|
|
||
| build: | ||
| docker build -t docker.io/stackstate/stackstate-agent-runner-gitlab:latest7 . | ||
| docker build --build-arg BASE_RUNNER_IMAGE_VERSION=$(BASE_RUNNER_IMAGE_VERSION) -t $(DOCKER_REPOSITORY)/stackstate/stackstate-agent-runner-gitlab:deb7_$(RUNTIMETAG) . | ||
| try: | ||
| docker run -it docker.io/stackstate/stackstate-agent-runner-gitlab:latest7 bash | ||
| docker run -it $(DOCKER_REPOSITORY)/stackstate/stackstate-agent-runner-gitlab:deb7_$(RUNTIMETAG) bash | ||
| push: | ||
| docker push docker.io/stackstate/stackstate-agent-runner-gitlab:latest7 | ||
| docker push $(DOCKER_REPOSITORY)/stackstate/stackstate-agent-runner-gitlab:deb7_$(RUNTIMETAG) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,10 +1,12 @@ | ||
| RUNTIMETAG := $(shell date +%Y%m%d) | ||
| TRY := 0 | ||
| DOCKER_REPOSITORY ?= docker.io | ||
| BASE_RUNNER_IMAGE_VERSION ?= centos7_latest | ||
|
|
||
| version: | ||
| echo $(RUNTIMETAG) | tail -1 > version.txt | ||
|
|
||
| build: | ||
| docker build -t docker.io/stackstate/stackstate-agent-runner-gitlab:centos7_latest_v7 . | ||
| docker build --build-arg BASE_RUNNER_IMAGE_VERSION=$(BASE_RUNNER_IMAGE_VERSION) -t $(DOCKER_REPOSITORY)/stackstate/stackstate-agent-runner-gitlab:centos7_$(RUNTIMETAG) . | ||
|
|
||
| push: | ||
| docker tag docker.io/stackstate/stackstate-agent-runner-gitlab:centos7_latest_v7 docker.io/stackstate/stackstate-agent-runner-gitlab:centos7_$(RUNTIMETAG)_v7_$(TRY) | ||
| docker tag docker.io/stackstate/stackstate-agent-runner-gitlab:centos7_latest_v7 docker.io/stackstate/stackstate-agent-runner-gitlab:centos7_$(RUNTIMETAG)_v7 | ||
| docker push docker.io/stackstate/stackstate-agent-runner-gitlab:centos7_latest_v7 | ||
| docker push docker.io/stackstate/stackstate-agent-runner-gitlab:centos7_$(RUNTIMETAG)_v7 | ||
| docker push docker.io/stackstate/stackstate-agent-runner-gitlab:centos7_$(RUNTIMETAG)_v7_$(TRY) | ||
| docker push $(DOCKER_REPOSITORY)/stackstate/stackstate-agent-runner-circle:centos7_$(RUNTIMETAG) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that I see this a second time in this review, I would offer the advice that we should probably not hard-code these in a Dockerfile, perhaps instead put it in gitlab-ci.yml file, or as gitlab environment variables. Doesn't have to happen today, but I think somebody should make a note (or a Jira ticket - Intermission perhaps).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Such approach usually leads to situation, when you are unable to do anything locally, without knowing what is in external setup. So I would keep defaults in, as it is now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the feedback, @LouisParkin !