Sync convolve and matmul convention#13
Merged
Transurgeon merged 2 commits intomainfrom Apr 23, 2026
Merged
Conversation
Bump SparseDiffEngine submodule to origin/main (45f88d0), which pulls in the new convolve atom plus dance858's cleanup of the dense matmul constructor data-pointer convention. new_left_matmul_dense / new_right_matmul_dense now require exactly one of param_node / data to be non-NULL (constants: (NULL, data); parameters: (capsule, NULL)) — the engine fprintf/exit(1)s otherwise. Update the dense branches of make_left_matmul and make_right_matmul bindings to match: drop the PARAM_FIXED wrapper we were building for the constant case, and forward data=NULL when a real parameter capsule is supplied. DNLP's helpers.py still hands in A.flatten() in both cases; the binding absorbs the new convention so no DNLP-side change is needed. Verified: SparseDiffEngine ctest (267/267), DNLP nlp_tests (217 passed, 77 skipped), DNLP test_convolution + test_atoms (119 passed). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Transurgeon
added a commit
that referenced
this pull request
Apr 23, 2026
* sync SparseDiffEngine and adapt dense matmul bindings Bump SparseDiffEngine submodule to origin/main (45f88d0), which pulls in the new convolve atom plus dance858's cleanup of the dense matmul constructor data-pointer convention. new_left_matmul_dense / new_right_matmul_dense now require exactly one of param_node / data to be non-NULL (constants: (NULL, data); parameters: (capsule, NULL)) — the engine fprintf/exit(1)s otherwise. Update the dense branches of make_left_matmul and make_right_matmul bindings to match: drop the PARAM_FIXED wrapper we were building for the constant case, and forward data=NULL when a real parameter capsule is supplied. DNLP's helpers.py still hands in A.flatten() in both cases; the binding absorbs the new convention so no DNLP-side change is needed. Verified: SparseDiffEngine ctest (267/267), DNLP nlp_tests (217 passed, 77 skipped), DNLP test_convolution + test_atoms (119 passed). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * trim comments on dense matmul bindings Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Will merge this once we sync with the 0.3.0 release.