PREQ-5138 authenticate NPM#230
PREQ-5138 authenticate NPM#230claire-villard-sonarsource merged 1 commit intoclaire/upgrade-libsfrom
Conversation
2456556 to
69186b2
Compare
|
SummaryThis PR adds NPM authentication to the CI workflow to support access to private packages (likely via JFrog Repox). It makes three key changes:
This enables the workflow to authenticate with the private NPM registry without embedding static credentials in the codebase. The actual authentication is delegated to the SonarSource reusable action, which likely exchanges the OIDC token for temporary Repox credentials. What reviewers should knowReviewer focus areas:
|
| runs-on: github-ubuntu-latest-s | ||
| permissions: | ||
| id-token: write | ||
| contents: write |
There was a problem hiding this comment.
Overly permissive scope: contents: write grants the ability to push commits and modify repository contents. This workflow only checks out code, installs dependencies, and runs tests — none of that requires write access.
The default contents: read is sufficient here. If config-npm@v1 genuinely requires contents: write, that should be documented — but it would be unusual for an NPM authentication action to need it.
Drop this to read unless there is a concrete reason it must be write.
| contents: write | |
| id-token: write | |
| contents: read |
- Mark as noise
335eaf6
into
claire/upgrade-libs



Depends on https://github.com/SonarSource/re-terraform-aws-vault/pull/8923