SONARJAVA-1306 Rule S1612: enable by default for source version 1.8

Author: mpaladin

java-checks/src/main/java/org/sonar/java/checks/ReplaceLambdaByMethodRefCheck.java

@@ -22,6 +22,8 @@
 import org.sonar.api.server.rule.RulesDefinition;
 import org.sonar.check.Priority;
 import org.sonar.check.Rule;
+import org.sonar.java.JavaVersionAwareVisitor;
+import org.sonar.java.checks.helpers.JavaVersionHelper;
 import org.sonar.java.tag.Tag;
 import org.sonar.plugins.java.api.JavaFileScanner;
 import org.sonar.plugins.java.api.JavaFileScannerContext;
@@ -35,6 +37,7 @@
 import org.sonar.plugins.java.api.tree.ReturnStatementTree;
 import org.sonar.plugins.java.api.tree.Tree;
 import org.sonar.plugins.java.api.tree.VariableTree;
+import org.sonar.squidbridge.annotations.ActivatedByDefault;
 import org.sonar.squidbridge.annotations.SqaleConstantRemediation;
 import org.sonar.squidbridge.annotations.SqaleSubCharacteristic;
 
@@ -47,12 +50,18 @@
   name = "Lambdas should be replaced with method references",
   priority = Priority.MINOR,
   tags = {Tag.JAVA_8})
+@ActivatedByDefault
 @SqaleSubCharacteristic(RulesDefinition.SubCharacteristics.READABILITY)
 @SqaleConstantRemediation("2min")
-public class ReplaceLambdaByMethodRefCheck extends BaseTreeVisitor implements JavaFileScanner {
+public class ReplaceLambdaByMethodRefCheck extends BaseTreeVisitor implements JavaFileScanner, JavaVersionAwareVisitor {
 
   private JavaFileScannerContext context;
 
+  @Override
+  public boolean isCompatibleWithJavaVersion(@Nullable Integer version) {
+    return JavaVersionHelper.java8Compatible(version);
+  }
+
   @Override
   public void scanFile(JavaFileScannerContext context) {
     this.context = context;

java-checks/src/test/java/org/sonar/java/checks/ReplaceLambdaByMethodRefCheckTest.java

@@ -24,9 +24,15 @@
 
 public class ReplaceLambdaByMethodRefCheckTest {
 
+  private static final String FILENAME = "src/test/files/checks/ReplaceLambdaByMethodRefCheck.java";
+
   @Test
-  public void detected() {
-    JavaCheckVerifier.verify("src/test/files/checks/ReplaceLambdaByMethodRefCheck.java", new ReplaceLambdaByMethodRefCheck());
+  public void java8() {
+    JavaCheckVerifier.verify(FILENAME, new ReplaceLambdaByMethodRefCheck(), 8);
   }
 
+  @Test
+  public void java7() {
+    JavaCheckVerifier.verifyNoIssue(FILENAME, new ReplaceLambdaByMethodRefCheck(), 7);
+  }
 }