SONARJAVA-1308 Rule S1710: enable by default for source version 1.8

Author: mpaladin

java-checks/src/main/java/org/sonar/java/checks/RepeatAnnotationCheck.java

@@ -22,6 +22,8 @@
 import org.sonar.api.server.rule.RulesDefinition;
 import org.sonar.check.Priority;
 import org.sonar.check.Rule;
+import org.sonar.java.JavaVersionAwareVisitor;
+import org.sonar.java.checks.helpers.JavaVersionHelper;
 import org.sonar.java.tag.Tag;
 import org.sonar.plugins.java.api.JavaFileScanner;
 import org.sonar.plugins.java.api.JavaFileScannerContext;
@@ -32,22 +34,30 @@
 import org.sonar.plugins.java.api.tree.MemberSelectExpressionTree;
 import org.sonar.plugins.java.api.tree.NewArrayTree;
 import org.sonar.plugins.java.api.tree.Tree;
+import org.sonar.squidbridge.annotations.ActivatedByDefault;
 import org.sonar.squidbridge.annotations.SqaleConstantRemediation;
 import org.sonar.squidbridge.annotations.SqaleSubCharacteristic;
 
+import javax.annotation.Nullable;
 import java.util.List;
 
 @Rule(
   key = "S1710",
   name = "Annotation repetitions should not be wrapped",
   priority = Priority.MAJOR,
   tags = {Tag.JAVA_8})
+@ActivatedByDefault
 @SqaleSubCharacteristic(RulesDefinition.SubCharacteristics.READABILITY)
 @SqaleConstantRemediation("2min")
-public class RepeatAnnotationCheck extends BaseTreeVisitor implements JavaFileScanner {
+public class RepeatAnnotationCheck extends BaseTreeVisitor implements JavaFileScanner, JavaVersionAwareVisitor {
 
   private JavaFileScannerContext context;
 
+  @Override
+  public boolean isCompatibleWithJavaVersion(@Nullable Integer version) {
+    return JavaVersionHelper.java8Guaranteed(version);
+  }
+
   @Override
   public void scanFile(JavaFileScannerContext context) {
     this.context = context;

java-checks/src/test/java/org/sonar/java/checks/RepeatAnnotationCheckTest.java

@@ -23,8 +23,21 @@
 import org.sonar.java.checks.verifier.JavaCheckVerifier;
 
 public class RepeatAnnotationCheckTest {
+
+  private static final String FILENAME = "src/test/files/checks/RepeatAnnotationCheck.java";
+
+  @Test
+  public void java8() {
+    JavaCheckVerifier.verify(FILENAME, new RepeatAnnotationCheck(), 8);
+  }
+
+  @Test
+  public void java7() {
+    JavaCheckVerifier.verifyNoIssue(FILENAME, new RepeatAnnotationCheck(), 7);
+  }
+
   @Test
-  public void test() {
-    JavaCheckVerifier.verify("src/test/files/checks/RepeatAnnotationCheck.java", new RepeatAnnotationCheck());
+  public void unknown_version() {
+    JavaCheckVerifier.verifyNoIssue(FILENAME, new RepeatAnnotationCheck(), null);
   }
 }