SONARJAVA-1503 Enum constants are implicitely final

Author: Wohops

java-squid/src/main/java/org/sonar/java/resolve/FirstPass.java

@@ -323,7 +323,8 @@ public void visitMethod(MethodTree tree) {
 
   @Override
   public void visitEnumConstant(EnumConstantTree tree) {
-    declareVariable(Flags.PUBLIC | Flags.STATIC | Flags.ENUM, tree.simpleName(), (VariableTreeImpl) tree);
+    // JLS-8.9.3
+    declareVariable(Flags.PUBLIC | Flags.STATIC | Flags.FINAL | Flags.ENUM, tree.simpleName(), (VariableTreeImpl) tree);
     super.visitEnumConstant(tree);
   }
 

java-squid/src/test/java/org/sonar/java/resolve/SymbolTableTest.java

@@ -300,7 +300,7 @@ public void EnumDeclaration() {
 
     JavaSymbol.VariableJavaSymbol variableSymbol = (JavaSymbol.VariableJavaSymbol) result.symbol("FIRST_CONSTANT");
     assertThat(variableSymbol.owner()).isSameAs(enumSymbol);
-    assertThat(variableSymbol.flags()).isEqualTo(Flags.PUBLIC | Flags.STATIC | Flags.ENUM);
+    assertThat(variableSymbol.flags()).isEqualTo(Flags.PUBLIC | Flags.STATIC | Flags.FINAL | Flags.ENUM);
 
     JavaSymbol.TypeJavaSymbol anonymousSymbol = (JavaSymbol.TypeJavaSymbol) result.symbol("method", 11).owner();
     assertThat(anonymousSymbol.name).isEqualTo("");
@@ -311,7 +311,7 @@ public void EnumDeclaration() {
 
     variableSymbol = (JavaSymbol.VariableJavaSymbol) result.symbol("SECOND_CONSTANT");
     assertThat(variableSymbol.owner()).isSameAs(enumSymbol);
-    assertThat(variableSymbol.flags()).isEqualTo(Flags.PUBLIC | Flags.STATIC | Flags.ENUM);
+    assertThat(variableSymbol.flags()).isEqualTo(Flags.PUBLIC | Flags.STATIC | Flags.FINAL | Flags.ENUM);
 
     anonymousSymbol = (JavaSymbol.TypeJavaSymbol) result.symbol("method", 16).owner();
     assertThat(anonymousSymbol.name).isEqualTo("");