SONARJAVA-1501 Enum constants are implicitely static

Author: benzonico

its/ruling/src/test/resources/sonar-server/squid-S2325.json

@@ -190,6 +190,7 @@
 193,
 ],
 'org.codehaus.sonar:sonar-server:src/main/java/org/sonar/server/permission/InternalPermissionService.java':[
+246,
 261,
 268,
 ],

java-checks/src/test/files/checks/StaticMethodCheck.java

@@ -91,3 +91,12 @@ private void recursive() { // Noncompliant
     recursive();
   }
 }
+
+static class FooBar {
+  enum MyEnum{
+    FOO;
+  }
+  private void plop() { // Noncompliant enum is static and enum constants are static
+    Object o = MyEnum.FOO;
+  }
+}

java-squid/src/main/java/org/sonar/java/resolve/FirstPass.java

@@ -323,7 +323,7 @@ public void visitMethod(MethodTree tree) {
 
   @Override
   public void visitEnumConstant(EnumConstantTree tree) {
-    declareVariable(Flags.PUBLIC | Flags.ENUM, tree.simpleName(), (VariableTreeImpl) tree);
+    declareVariable(Flags.PUBLIC | Flags.STATIC | Flags.ENUM, tree.simpleName(), (VariableTreeImpl) tree);
     super.visitEnumConstant(tree);
   }
 

java-squid/src/test/java/org/sonar/java/resolve/SymbolTableTest.java

@@ -300,7 +300,7 @@ public void EnumDeclaration() {
 
     JavaSymbol.VariableJavaSymbol variableSymbol = (JavaSymbol.VariableJavaSymbol) result.symbol("FIRST_CONSTANT");
     assertThat(variableSymbol.owner()).isSameAs(enumSymbol);
-    assertThat(variableSymbol.flags()).isEqualTo(Flags.PUBLIC | Flags.ENUM);
+    assertThat(variableSymbol.flags()).isEqualTo(Flags.PUBLIC | Flags.STATIC | Flags.ENUM);
 
     JavaSymbol.TypeJavaSymbol anonymousSymbol = (JavaSymbol.TypeJavaSymbol) result.symbol("method", 11).owner();
     assertThat(anonymousSymbol.name).isEqualTo("");
@@ -311,7 +311,7 @@ public void EnumDeclaration() {
 
     variableSymbol = (JavaSymbol.VariableJavaSymbol) result.symbol("SECOND_CONSTANT");
     assertThat(variableSymbol.owner()).isSameAs(enumSymbol);
-    assertThat(variableSymbol.flags()).isEqualTo(Flags.PUBLIC | Flags.ENUM);
+    assertThat(variableSymbol.flags()).isEqualTo(Flags.PUBLIC | Flags.STATIC | Flags.ENUM);
 
     anonymousSymbol = (JavaSymbol.TypeJavaSymbol) result.symbol("method", 16).owner();
     assertThat(anonymousSymbol.name).isEqualTo("");