SONARJAVA-1390 Enable precise issue location on S109

Author: Wohops

java-checks/src/main/java/org/sonar/java/checks/MagicNumberCheck.java

@@ -95,7 +95,7 @@ public void visitLiteral(LiteralTree tree) {
         // noop case not encountered
       }
       if (checked != null && !isExcluded(checked)) {
-        context.addIssue(tree, this, "Assign this magic number " + tree.value() + " to a well-named constant, and use the constant instead.");
+        context.reportIssue(this, tree, "Assign this magic number " + tree.value() + " to a well-named constant, and use the constant instead.");
       }
     }
   }

java-checks/src/test/files/checks/MagicNumberCheck.java

@@ -12,12 +12,12 @@ final class A {
   int b = 1;
   int c = -1;
 
-  int d = 2; // Noncompliant {{Assign this magic number 2 to a well-named constant, and use the constant instead.}}
-  int e = 42; // Noncompliant {{Assign this magic number 42 to a well-named constant, and use the constant instead.}}
+  int d = 2; // Noncompliant [[sc=11;ec=12]] {{Assign this magic number 2 to a well-named constant, and use the constant instead.}}
+  int e = 42; // Noncompliant [[sc=11;ec=13]] {{Assign this magic number 42 to a well-named constant, and use the constant instead.}}
 
-  long aLong = 12L; // Noncompliant {{Assign this magic number 12L to a well-named constant, and use the constant instead.}}
-  double aDouble = 12.3d; // Noncompliant {{Assign this magic number 12.3d to a well-named constant, and use the constant instead.}}
-  float aFloat = 12.3F; // Noncompliant {{Assign this magic number 12.3F to a well-named constant, and use the constant instead.}}
+  long aLong = 12L; // Noncompliant [[sc=16;ec=19]] {{Assign this magic number 12L to a well-named constant, and use the constant instead.}}
+  double aDouble = 12.3d; // Noncompliant [[sc=20;ec=25]] {{Assign this magic number 12.3d to a well-named constant, and use the constant instead.}}
+  float aFloat = 12.3F; // Noncompliant [[sc=18;ec=23]] {{Assign this magic number 12.3F to a well-named constant, and use the constant instead.}}
   String string = "string";
   String strDouble = "123.3d";
   boolean bool = true;

java-checks/src/test/files/checks/MagicNumberCheckCustom.java

@@ -13,7 +13,7 @@ final class A {
   int c = -1;
 
   int d = 2;
-  int e = 42; // Noncompliant {{Assign this magic number 42 to a well-named constant, and use the constant instead.}}
+  int e = 42; // Noncompliant [[sc=11;ec=13]] {{Assign this magic number 42 to a well-named constant, and use the constant instead.}}
 
   long aLong = 12L; // Noncompliant {{Assign this magic number 12L to a well-named constant, and use the constant instead.}}
   double aDouble = 12.3d; // Noncompliant {{Assign this magic number 12.3d to a well-named constant, and use the constant instead.}}