SONARJAVA-1329 Ignore hashcode method

Author: Wohops

its/ruling/src/test/resources/commons-beanutils/squid-S109.json

@@ -1,9 +1,4 @@
 {
-'commons-beanutils:commons-beanutils:src/main/java/org/apache/commons/beanutils/DynaProperty.java':[
-239,
-240,
-241,
-],
 'commons-beanutils:commons-beanutils:src/main/java/org/apache/commons/beanutils/MappedPropertyDescriptor.java':[
 120,
 176,
@@ -25,9 +20,6 @@
 1625,
 1794,
 ],
-'commons-beanutils:commons-beanutils:src/main/java/org/apache/commons/beanutils/WrapDynaClass.java':[
-520,
-],
 'commons-beanutils:commons-beanutils:src/main/java/org/apache/commons/beanutils/converters/DateTimeConverter.java':[
 300,
 300,

its/ruling/src/test/resources/guava/squid-S109.json

@@ -18,10 +18,6 @@
 947,
 1358,
 ],
-'com.google.guava:guava:src/com/google/common/base/Converter.java':[
-349,
-442,
-],
 'com.google.guava:guava:src/com/google/common/base/Joiner.java':[
 457,
 468,
@@ -113,7 +109,6 @@
 193,
 194,
 195,
-575,
 ],
 'com.google.guava:guava:src/com/google/common/collect/ImmutableSet.java':[
 69,
@@ -144,9 +139,6 @@
 314,
 1303,
 ],
-'com.google.guava:guava:src/com/google/common/collect/LexicographicalOrdering.java':[
-70,
-],
 'com.google.guava:guava:src/com/google/common/collect/LinkedHashMultimap.java':[
 443,
 ],
@@ -207,27 +199,18 @@
 'com.google.guava:guava:src/com/google/common/collect/Multisets.java':[
 367,
 ],
-'com.google.guava:guava:src/com/google/common/collect/NullsFirstOrdering.java':[
-73,
-],
-'com.google.guava:guava:src/com/google/common/collect/NullsLastOrdering.java':[
-73,
-],
 'com.google.guava:guava:src/com/google/common/collect/Ordering.java':[
 658,
 695,
 720,
 ],
 'com.google.guava:guava:src/com/google/common/collect/Range.java':[
-639,
 651,
 ],
 'com.google.guava:guava:src/com/google/common/collect/RegularImmutableTable.java':[
 162,
 ],
 'com.google.guava:guava:src/com/google/common/collect/Sets.java':[
-1220,
-1226,
 1292,
 1318,
 ],
@@ -250,10 +233,6 @@
 122,
 193,
 ],
-'com.google.guava:guava:src/com/google/common/eventbus/Subscriber.java':[
-117,
-117,
-],
 'com.google.guava:guava:src/com/google/common/hash/AbstractNonStreamingHashFunction.java':[
 35,
 52,
@@ -342,8 +321,6 @@
 364,
 366,
 376,
-406,
-413,
 432,
 434,
 ],
@@ -363,7 +340,6 @@
 518,
 528,
 532,
-553,
 569,
 570,
 ],
@@ -662,27 +638,22 @@
 63,
 63,
 257,
-462,
 469,
 ],
 'com.google.guava:guava:src/com/google/common/primitives/Bytes.java':[
-375,
 382,
 ],
 'com.google.guava:guava:src/com/google/common/primitives/Chars.java':[
 294,
 324,
-576,
 583,
 ],
 'com.google.guava:guava:src/com/google/common/primitives/Doubles.java':[
 361,
-567,
 574,
 ],
 'com.google.guava:guava:src/com/google/common/primitives/Floats.java':[
 357,
-562,
 569,
 ],
 'com.google.guava:guava:src/com/google/common/primitives/Ints.java':[
@@ -695,7 +666,6 @@
 336,
 336,
 423,
-624,
 631,
 650,
 654,
@@ -728,7 +698,6 @@
 356,
 359,
 458,
-660,
 667,
 ],
 'com.google.guava:guava:src/com/google/common/primitives/ParseRequest.java':[
@@ -746,7 +715,6 @@
 302,
 334,
 421,
-623,
 630,
 ],
 'com.google.guava:guava:src/com/google/common/primitives/SignedBytes.java':[

its/ruling/src/test/resources/java-squid/squid-S109.json

@@ -21,8 +21,6 @@
 'org.sonarsource.java:java-squid:src/main/java/org/sonar/java/resolve/JavaType.java':[
 87,
 98,
-279,
-279,
 ],
 'org.sonarsource.java:java-squid:src/main/java/org/sonar/java/resolve/Types.java':[
 40,

its/ruling/src/test/resources/sonar-server/squid-S109.json

@@ -397,13 +397,6 @@
 'org.codehaus.sonar:sonar-server:src/main/java/org/sonar/server/es/SearchOptions.java':[
 105,
 ],
-'org.codehaus.sonar:sonar-server:src/main/java/org/sonar/server/es/request/ProxyBulkRequestBuilder.java':[
-156,
-157,
-],
-'org.codehaus.sonar:sonar-server:src/main/java/org/sonar/server/exceptions/Message.java':[
-78,
-],
 'org.codehaus.sonar:sonar-server:src/main/java/org/sonar/server/issue/InternalRubyIssueService.java':[
 340,
 341,
@@ -414,8 +407,6 @@
 'org.codehaus.sonar:sonar-server:src/main/java/org/sonar/server/issue/Result.java':[
 81,
 84,
-147,
-148,
 ],
 'org.codehaus.sonar:sonar-server:src/main/java/org/sonar/server/issue/index/IssueAuthorizationDao.java':[
 179,
@@ -525,9 +516,6 @@
 208,
 208,
 ],
-'org.codehaus.sonar:sonar-server:src/main/java/org/sonar/server/qualityprofile/QProfileName.java':[
-62,
-],
 'org.codehaus.sonar:sonar-server:src/main/java/org/sonar/server/qualityprofile/index/ActiveRuleIndex.java':[
 128,
 ],
@@ -575,9 +563,6 @@
 64,
 77,
 ],
-'org.codehaus.sonar:sonar-server:src/main/java/org/sonar/server/source/OpeningHtmlTag.java':[
-54,
-],
 'org.codehaus.sonar:sonar-server:src/main/java/org/sonar/server/source/index/SourceFileResultSetIterator.java':[
 106,
 107,

java-checks/src/main/java/org/sonar/java/checks/MagicNumberCheck.java

@@ -23,6 +23,7 @@
 import org.sonar.check.Priority;
 import org.sonar.check.Rule;
 import org.sonar.check.RuleProperty;
+import org.sonar.java.model.declaration.MethodTreeImpl;
 import org.sonar.java.tag.Tag;
 import org.sonar.plugins.java.api.JavaFileScanner;
 import org.sonar.plugins.java.api.JavaFileScannerContext;
@@ -31,6 +32,7 @@
 import org.sonar.plugins.java.api.tree.EnumConstantTree;
 import org.sonar.plugins.java.api.tree.ExpressionTree;
 import org.sonar.plugins.java.api.tree.LiteralTree;
+import org.sonar.plugins.java.api.tree.MethodTree;
 import org.sonar.plugins.java.api.tree.NewArrayTree;
 import org.sonar.plugins.java.api.tree.Tree;
 import org.sonar.plugins.java.api.tree.Tree.Kind;
@@ -124,4 +126,11 @@ public void visitVariable(VariableTree tree) {
       super.visitVariable(tree);
     }
   }
+
+  @Override
+  public void visitMethod(MethodTree tree) {
+    if (!((MethodTreeImpl) tree).isHashCodeMethod()) {
+      super.visitMethod(tree);
+    }
+  }
 }

java-checks/src/test/files/checks/MagicNumberCheck.java

@@ -78,6 +78,11 @@ protected char[] initialValue() {
     }
   };
 
+  @Override
+  public int hashCode() {
+    return 42; // Compliant
+  }
+
   int nothing;
 }