Fix quality flaws

Author: benzonico

java-checks/src/main/java/org/sonar/java/checks/CallOuterPrivateMethodCheck.java

@@ -86,7 +86,7 @@ public void visitMethodInvocation(MethodInvocationTree tree) {
     }
 
     private boolean isPrivateMethodOfOuterClass(Symbol symbol) {
-      return symbol.isPrivate() && symbol.owner() == classSymbol.owner();
+      return symbol.isPrivate() && symbol.owner().equals(classSymbol.owner());
     }
 
     public void checkUsages() {

java-checks/src/test/files/checks/CallOuterPrivateMethodCheck.java

@@ -16,7 +16,9 @@ void plop() {
       baz();
       baz();
       baz();
+      innerFun();
     }
+    private void innerFun() {}
   }
 
 }

java-jacoco/src/main/java/org/sonar/plugins/jacoco/JaCoCoSensor.java

@@ -19,7 +19,6 @@
  */
 package org.sonar.plugins.jacoco;
 
-import org.sonar.api.batch.DependsUpon;
 import org.sonar.api.batch.Sensor;
 import org.sonar.api.batch.SensorContext;
 import org.sonar.api.batch.fs.FileSystem;
@@ -53,14 +52,6 @@ public JaCoCoSensor(JacocoConfiguration configuration, ResourcePerspectives pers
     this.javaClasspath = javaClasspath;
   }
 
-  /**
-   * Should be executed after Surefire, which imports details of the tests.
-   */
-  @DependsUpon
-  public String dependsOnSurefireSensors() {
-    return "surefire-java";
-  }
-
   @Override
   public void analyse(Project project, SensorContext context) {
     new UnitTestsAnalyzer(perspectives).analyse(project, context);

java-jacoco/src/test/java/org/sonar/plugins/jacoco/JaCoCoSensorTest.java

@@ -95,11 +95,6 @@ public void testSensorDefinition() {
     assertThat(sensor.toString()).isEqualTo("JaCoCoSensor");
   }
 
-  @Test
-  public void should_depend_on_surefire() {
-    assertThat(sensor.dependsOnSurefireSensors()).isEqualTo("surefire-java");
-  }
-
   @Test
   public void should_execute_if_report_exists() {
     Project project = mock(Project.class);