Conversation
…ts for model itself are missing
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1518 +/- ##
==========================================
+ Coverage 97.40% 97.43% +0.02%
==========================================
Files 190 190
Lines 16866 15963 -903
==========================================
- Hits 16428 15553 -875
+ Misses 438 410 -28 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mknaranja
left a comment
There was a problem hiding this comment.
Thank you very much for this great feature. So far I have only gone through the documentation. I will try to check functionality and core code more closely but this could maybe help to improve the documentation,
Co-authored-by: Martin J. Kühn <62713180+mknaranja@users.noreply.github.com>
774e5fe to
d552a34
Compare
…custom lower bound
mknaranja
left a comment
There was a problem hiding this comment.
I get memilio-modelgenerator: command not found after pip install -e pycode/memilio-generation and memilio-modelgenerator pycode/examples/modelgenerator/seir.yaml ./
kilianvolmer
left a comment
There was a problem hiding this comment.
Thank you for writing this really good and extensive documentation! I added a few typo fixes. Apart from that I only have three minor concerns/suggestions:
- I think it is quite confusing to add
nullas indicator that there is no upper limit. Maybe this could be changed toNoneor something similar? - Could you please add a sentence on reinstalling memilio-simulation for people who installed it using pypy?
- It took me a second to understand that Development and extension is not about a SEIR model as used in the documentation, but about new features for the generator. Could you maybe add one more sentence on that or move this section to a separate file?
Co-authored-by: Martin J. Kühn <62713180+mknaranja@users.noreply.github.com> Co-authored-by: Kilian Volmer <13285635+kilianvolmer@users.noreply.github.com>
Great points, thank you. Regarding the first point. Internally, PyYAML directly converts |
mknaranja
left a comment
There was a problem hiding this comment.
Thank you for all the continuous changes, I basically have three comments / questions that are remaining:
- Can we do clang-format on the generated files?
- We could probably also generate probabilities for transitions (to R vs to D), right?
- In the SEIRD model, we include D in the total population size for the denominator. The generator probably uses all compartments, right? It is probably to much right now to designate which states should go in the denominator but we should write a comment on this in the documentation and open an issue for this.
Otherwise, I only tested running and looked into the results. I haven't gone through the code line-by-line anymore.
Thank you for the feedback.
|

Changes and Information
Please briefly list the changes (main added features, changed items, or corrected bugs) made:
If need be, add additional information and what the reviewer should look out for in particular:
Merge Request - Guideline Checklist
Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.
Checks by code author
Checks by code reviewer(s)