Avoid Raw Pointers in CSR Solver

[julianlitz]

Merge Request - GuideLine Checklist

Guideline to check code before resolve WIP and approval, respectively.
As many checkboxes as possible should be ticked.

Checks by code author:

Always to be checked:

• There is at least one issue associated with the pull request.
• New code adheres with the coding guidelines
• No large data files have been added to the repository. Maximum size for files should be of the order of KB not MB. In particular avoid adding of pdf, word, or other files that cannot be change-tracked correctly by git.

If functions were changed or functionality was added:

• Tests for new functionality has been added
• A local test was succesful

If new functionality was added:

• There is appropriate documentation of your work. (use doxygen style comments)

If new third party software is used:

• Did you pay attention to its license? Please remember to add it to the wiki after successful merging.

If new mathematical methods or epidemiological terms are used:

• Are new methods referenced? Did you provide further documentation?

Checks by code reviewer(s):

• Is the code clean of development artifacts e.g., unnecessary comments, prints, ...
• The ticket goals for each associated issue are reached or problems are clearly addressed (i.e., a new issue was introduced).
• There are appropriate unit tests and they pass.
• The git history is clean and linearized for the merge request. All reviewers should squash commits and write a simple and meaningful commit message.
• Coverage report for new code is acceptable.
• No large data files have been added to the repository. Maximum size for files should be of the order of KB not MB. In particular avoid adding of pdf, word, or other files that cannot be change-tracked correctly by git.

[julianlitz]

Requires #206 to be merged first

[EmilyBourne]

I agree with this PR. I'm not sure why it would need to wait for #206 (#246) ? But the other calls to the solveInPlace function need updating

[julianlitz]

SolveAsc (in the smoother) was * pointer based for the inner boundary, but I switched to a kokkos vector there with these PRs.

[julianlitz]

[EmilyBourne]

On v100 at 498c883

100% tests passed, 0 tests failed out of 268

[EmilyBourne]

On v100 at 64e7783

100% tests passed, 0 tests failed out of 268

[EmilyBourne]

@julianlitz I merged in main so I took this out of draft to run the tests. Was there another reason you put it into draft or can I safely merge?

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.04%. Comparing base (eb05299) to head (64e7783).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #216   +/-   ##
=======================================
  Coverage   90.04%   90.04%           
=======================================
  Files          79       79           
  Lines        8791     8791           
=======================================
  Hits         7916     7916           
  Misses        875      875           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[julianlitz]

You can merge if you like to. Since you already did the same in your COO Modifications here only a & is added

[EmilyBourne]

You can merge if you like to. Since you already did the same in your COO Modifications here only a & is added

Ah true, should have checked the diff 😆