Open
Conversation
Contributor
|
Thanks for the PR! This section of the codebase is owned by @madskristensen and |
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Pull request overview
Adds SchemaStore catalog support for detecting XenForo add-on manifests (addon.json) so editors can auto-associate the XenForo schema for validation and completion.
Changes:
- Register “XenForo add-on manifest” in the JSON schema catalog.
- Add a
fileMatchglob targeting XenForo add-on manifest locations. - Point the catalog entry to XenForo’s published schema URL.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This is too narrow as there isn't necessarily a vendor. This reverts commit 13c902f.
Contributor
|
is this ready to merge? |
Author
|
Yes 🙂 |
Member
|
I myself wont be merging this as-is, since I think match |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a schema for XenForo
addon.jsonfiles. We may land support for naming themaddon.xf.jsonin the future to allow resolution from add-on root folders.