Skip to content

Files: fix build failure after sysdb_enumpwent removal#8677

Merged
ikerexxe merged 1 commit intoSSSD:sssd-2-9from
ikerexxe:fix-sssd-2-9
May 7, 2026
Merged

Files: fix build failure after sysdb_enumpwent removal#8677
ikerexxe merged 1 commit intoSSSD:sssd-2-9from
ikerexxe:fix-sssd-2-9

Conversation

@ikerexxe
Copy link
Copy Markdown
Contributor

@ikerexxe ikerexxe commented May 7, 2026

The files provider was still calling the removed sysdb_enumpwent() function, causing compilation failures. Replace the call with the equivalent sysdb_enumpwent_filter() function.

Fixes: 77e17cc ("SYSDB: Remove unused function")

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the get_cached_user_names function in src/providers/files/files_ops.c to use sysdb_enumpwent_filter instead of sysdb_enumpwent. There are no review comments to address, and I have no further feedback to provide.

@ikerexxe ikerexxe added Waiting for review Trivial A single reviewer is sufficient to review the Pull Request labels May 7, 2026
@ikerexxe ikerexxe requested a review from alexey-tikhonov May 7, 2026 07:39
@alexey-tikhonov alexey-tikhonov requested a review from aplopez May 7, 2026 07:41
@alexey-tikhonov alexey-tikhonov added the no-backport This should go to target branch only. label May 7, 2026
Copy link
Copy Markdown
Contributor

@aplopez aplopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK.

@aplopez aplopez self-assigned this May 7, 2026
The files provider was still calling the removed sysdb_enumpwent()
function, causing compilation failures. Replace the call with the
equivalent sysdb_enumpwent_filter() function.

Fixes: 77e17cc ("SYSDB: Remove unused function")
Signed-off-by: Iker Pedrosa <ipedrosa@redhat.com>
Reviewed-by: Alexey Tikhonov <atikhono@redhat.com>
Reviewed-by: Alejandro López <allopez@redhat.com>
@sssd-bot
Copy link
Copy Markdown
Contributor

sssd-bot commented May 7, 2026

The pull request was accepted by @ikerexxe with the following PR CI status:


🟢 CodeQL (success)
🟢 rpm-build:centos-stream-9-x86_64:upstream (success)
🟢 Build / make-distcheck (success)
🟢 ci / prepare (success)
🟢 ci / system (centos-9) (success)
🟢 Static code analysis / codeql (success)
🟢 Static code analysis / pre-commit (success)
🟢 Static code analysis / python-system-tests (success)


There are unsuccessful or unfinished checks. Make sure that the failures are not related to this pull request before merging.

@ikerexxe ikerexxe merged commit 9f623fa into SSSD:sssd-2-9 May 7, 2026
7 of 8 checks passed
@ikerexxe ikerexxe deleted the fix-sssd-2-9 branch May 7, 2026 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Accepted no-backport This should go to target branch only. Trivial A single reviewer is sufficient to review the Pull Request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants