Feat: Add support for configurable cache directory#4869
Conversation
| ) | ||
| ), | ||
| model_defaults=model_defaults, | ||
| cache_dir="{custom_cache_dir}", |
There was a problem hiding this comment.
I think injecting the path as a quoted string here is breaking the tests on Windows, because it ends up being cache_dir="C:\some\path" and the \ is treated as an escape
There was a problem hiding this comment.
thanks you’re right updated the test to use as posix to have forward slashes in all platforms
erindru
left a comment
erindru
left a comment
There was a problem hiding this comment.
Looks good, this will definitely help in Notebook environments (Fabric in particular) which limit the number of files in the persistent storage.
I notice that cache_dir vs cache_path is used a bit inconsistently though? Should it be one or the other?
| schema = context.config.get_state_schema(context.gateway) | ||
| return EngineAdapterStateSync( | ||
| engine_adapter, schema=schema, context_path=context.path, console=context.console | ||
| engine_adapter, schema=schema, context_path=context.cache_dir, console=context.console |
There was a problem hiding this comment.
Should the context_path parameter be renamed to cache_dir?
There was a problem hiding this comment.
yes good point renamed to use the cache_dir name here and everywhere else that I was using cache_path for consistency
themisvaltinos
force-pushed
the
themis/cache
branch
from
5c35a90 to
cca8703
Compare
themisvaltinos
force-pushed
the
themis/cache
branch
from
cca8703 to
6bd9463
Compare
2 participants
By default SQLMesh stores its cache in a
.cachefolder inside the project directory. This introduces a configuration option to specify a custom cache location, either as a relative path or an absolute path. Fixes: #4307