Open
Conversation
nevalsar
requested changes
Mar 13, 2024
Collaborator
There was a problem hiding this comment.
Thank you for sending in the PR! I have some broad comments about the content being added.
- The page is essentially a link to a YouTube video for a specific network configuration (namely, projects running in CMU RI). Some alternatives that would better suit the audience and content of this wiki are:
- A plaintext write-up of the video content, which makes it straightforward to keep the guide up to date without having to redo the entire video / maintaining a coupled errata.
- A compilation of resources (video or otherwise) that cover a range of networking setups encountered in robotics projects.
- The included description for the video is very open ended and does not quite illustrate what to expect at the linked resource - the description does not specify the kind of platform, network infrastructure or the expected outcome which this resource helps achieve. A helpful description can be something like: “Video tutorial for configuring static IP on a Linux machine for remote login and monitoring”, or "network configuration for real-time image processing over a congested network".
- Keep in mind that this wiki is intended for a larger audience not restricted to CMU RI. It would be much better to keep the instructions general, with any CMU-specific configuration called out separately.
Disclaimer: I did not go through the full content of the video (it's quite long) but that serves to illustrate my point about videos being hard to maintain, update or even skim through.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a wiki entry describing a networking setup for use in robotics projects.