Drop proposed mappings from the files#278
Conversation
eristhea
added
enhancement
| // continue; | ||
| // } | ||
|
|
||
| if (proposedMapping.getValue().sourcePluginId().equals("quiltmc:name_proposal/delegate_params")) { |
There was a problem hiding this comment.
this should preserve fallback-proposed names as well
also why do delegate params need an exception?
There was a problem hiding this comment.
I believe this was a work around until we figure out why we are getting the massive spooky diffs,
There was a problem hiding this comment.
ah, ok
it could be a useful to have an arg for proposer plugin ids to exclude
There was a problem hiding this comment.
potentially, but i also feel like that defeats a bit of the purpose of this feature, which is to make sure that no more proposed names are left in the mappings. If the proposer is fragile enough to break with this, its probably not written very well.
There was a problem hiding this comment.
true
I wouldn't expect it to be used often
maybe it would be better not to have an arg; if a proposer is having issues it can just be set to fallback as a workaround
| return this.secondaryTree.get(entry); | ||
| } | ||
|
|
||
| if (main.tokenType().equals(TokenType.OBFUSCATED) && this.secondaryTree.contains(entry)) { |
There was a problem hiding this comment.
@ix0rai what is your opinion on this? it allows for javadocs to be on empty mappings, but get a name from a proposer
There was a problem hiding this comment.
just making sure you know i'm not ignoring you, i'm pretty busy rn and i want to look into javadoc support on obf mappings a bit deeper
3 participants
No description provided.