Add execution windows to runtime settings#2
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6f1730bb59
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| ) | ||
| if "offset_minutes" in window: | ||
| offset_minutes = window["offset_minutes"] | ||
| if not isinstance(offset_minutes, int) or offset_minutes < 0: |
There was a problem hiding this comment.
offset_minutes is intended to be numeric, but this check treats booleans as valid because bool is a subclass of int in Python. As a result, configs like "offset_minutes": true pass validate_target() even though the schema declares this field as an integer, so invalid runtime targets can be accepted and propagated to downstream systems.
Useful? React with 👍 / 👎.
1 participant
Add
runtime_target.execution_windowsto the canonical runtime target schema and validation logic, plus update the examples and docs to describe precheck/execution scheduling.Tests: